From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 18 Apr 2018 17:52:09 +0200 From: Greg Kroah-Hartman To: Alexey Brodkin Cc: dri-devel@lists.freedesktop.org, Borislav Petkov , "Tobin C . Harding" , Alex Deucher , Andrey Grodzovsky , Arnd Bergmann , Benjamin Gaignard , Chen-Yu Tsai , Christian Gmeiner , Christian =?iso-8859-1?Q?K=F6nig?= , Cihangir Akturk , CK Hu , Daniel Vetter , Dave Airlie , David Airlie , "David (ChunMing) Zhou" , Gerd Hoffmann , Gustavo Padovan , Harry Wentland , Heiko =?iso-8859-1?Q?St=FCbner?= , Ingo Molnar , Jani Nikula , "Jerry (Fangzhi) Zuo" , Joonas Lahtinen , Krzysztof Kozlowski , "Leo (Sunpeng) Li" , Lucas Stach , Maarten Lankhorst , Matthias Brugger , Maxime Ripard , Michel =?iso-8859-1?Q?D=E4nzer?= , Oded Gabbay , Philipp Zabel , Rob Clark , Rodrigo Vivi , Roger He , Roman Li , Russell King , Samuel Li , Sandy Huang , Sean Paul , Shirish S , Sinclair Yeh , Thomas Hellstrom , Tom Lendacky , Tony Cheng , Vincent Abriou , VMware Graphics , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drm: Print unadorned pointers Message-ID: <20180418155209.GA1634@kroah.com> References: <20180418092450.13798-1-abrodkin@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180418092450.13798-1-abrodkin@synopsys.com> User-Agent: Mutt/1.9.5 (2018-04-13) X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Apr 18, 2018 at 12:24:50PM +0300, Alexey Brodkin wrote: > After commit ad67b74 ("printk: hash addresses printed with %p") > pointers are being hashed when printed. However, this makes > debug output completely useless. Switch to %px in order to see the > unadorned kernel pointers. > > This was done with the following one-liner: > find drivers/gpu/drm -type f -name "*.c" -exec sed -r -i '/DRM_DEBUG|KERN_DEBUG|pr_debug/ s/%p\b/%px/g' {} + > > Signed-off-by: Alexey Brodkin > Cc: Borislav Petkov > Cc: Tobin C. Harding > Cc: Alex Deucher > Cc: Andrey Grodzovsky > Cc: Arnd Bergmann > Cc: Benjamin Gaignard > Cc: Chen-Yu Tsai > Cc: Christian Gmeiner > Cc: "Christian König" > Cc: Cihangir Akturk > Cc: CK Hu > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: David Airlie > Cc: "David (ChunMing) Zhou" > Cc: Gerd Hoffmann > Cc: Greg Kroah-Hartman > Cc: Gustavo Padovan > Cc: Harry Wentland > Cc: "Heiko Stübner" > Cc: Ingo Molnar > Cc: Jani Nikula > Cc: "Jerry (Fangzhi) Zuo" > Cc: Joonas Lahtinen > Cc: Krzysztof Kozlowski > Cc: "Leo (Sunpeng) Li" > Cc: Lucas Stach > Cc: Maarten Lankhorst > Cc: Matthias Brugger > Cc: Maxime Ripard > Cc: "Michel Dänzer" > Cc: Oded Gabbay > Cc: Philipp Zabel > Cc: Rob Clark > Cc: Rodrigo Vivi > Cc: Roger He > Cc: Roman Li > Cc: Russell King > Cc: Samuel Li > Cc: Sandy Huang > Cc: Sean Paul > Cc: Shirish S > Cc: Sinclair Yeh > Cc: Thomas Hellstrom > Cc: Tom Lendacky > Cc: Tony Cheng > Cc: Vincent Abriou > Cc: VMware Graphics > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: etnaviv@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Cc: virtualization@lists.linux-foundation.org > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 14 +++---- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 +- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 4 +- > drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c | 2 +- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 10 ++--- > drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 4 +- > drivers/gpu/drm/amd/amdkfd/kfd_events.c | 4 +- > drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 2 +- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 +- > drivers/gpu/drm/amd/amdkfd/kfd_queue.c | 18 ++++----- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++---- > .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > drivers/gpu/drm/armada/armada_gem.c | 12 +++--- > drivers/gpu/drm/drm_atomic.c | 44 +++++++++++----------- > drivers/gpu/drm/drm_bufs.c | 8 ++-- > drivers/gpu/drm/drm_dp_mst_topology.c | 4 +- > drivers/gpu/drm/drm_lease.c | 6 +-- > drivers/gpu/drm/drm_lock.c | 2 +- > drivers/gpu/drm/drm_scatter.c | 4 +- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 6 +-- > drivers/gpu/drm/i810/i810_dma.c | 2 +- > drivers/gpu/drm/i915/i915_perf.c | 2 +- > drivers/gpu/drm/i915/intel_display.c | 2 +- > drivers/gpu/drm/i915/intel_guc_ct.c | 4 +- > drivers/gpu/drm/i915/intel_guc_submission.c | 2 +- > drivers/gpu/drm/i915/intel_uc_fw.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- > drivers/gpu/drm/mga/mga_warp.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 4 +- > drivers/gpu/drm/qxl/qxl_cmd.c | 4 +- > drivers/gpu/drm/qxl/qxl_fb.c | 2 +- > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > drivers/gpu/drm/radeon/radeon_display.c | 2 +- > drivers/gpu/drm/radeon/radeon_dp_mst.c | 12 +++--- > drivers/gpu/drm/radeon/radeon_object.c | 2 +- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- > drivers/gpu/drm/savage/savage_bci.c | 2 +- > drivers/gpu/drm/sti/sti_gdp.c | 4 +- > drivers/gpu/drm/sti/sti_mixer.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_crtc.c | 4 +- > drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 +- > drivers/gpu/drm/udl/udl_fb.c | 2 +- > drivers/gpu/drm/via/via_dma.c | 4 +- > drivers/gpu/drm/via/via_irq.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 2 +- > 45 files changed, 120 insertions(+), 120 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > index 1d6e1479da38..32e85fe83152 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > @@ -438,7 +438,7 @@ static int add_bo_to_vm(struct amdgpu_device *adev, struct kgd_mem *mem, > if (!bo_va_entry) > return -ENOMEM; > > - pr_debug("\t add VA 0x%llx - 0x%llx to vm %p\n", va, > + pr_debug("\t add VA 0x%llx - 0x%llx to vm %px\n", va, > va + bo_size, vm); > > /* Add BO to VM internal data structures*/ As others have pointed out, please do not do this. Use %pK as needed. And perhaps revisit some of the "need" for these pointers at all in the first place... thanks, greg k-h