From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
Date: Wed, 18 Apr 2018 22:38:09 +0200 [thread overview]
Message-ID: <20180418203808.GQ30543@wotan.suse.de> (raw)
In-Reply-To: <20180404203848.3txsangsvaxtxsu4@xylophone.i.decadent.org.uk>
On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote:
> Commit 65c79230576 tried to clear the custom firmware path on exit by
> writing a single space to the firmware_class.path parameter. This
> doesn't work because nothing strips this space from the value stored
> and fw_get_filesystem_firmware() only ignores zero-length paths.
>
> Instead, write a null byte.
>
> Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Greg, let me know if you want to take these two in now, or if you want me to
queue them up on my own and then send you what I get in the queue later.
Luis
next prev parent reply other threads:[~2018-04-18 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 20:37 [PATCH driver-core 1/2] test_firmware: Install all scripts Ben Hutchings
2018-04-04 20:38 ` [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try Ben Hutchings
2018-04-18 20:38 ` Luis R. Rodriguez [this message]
2018-04-23 10:45 ` Greg Kroah-Hartman
2018-04-18 20:35 ` [PATCH driver-core 1/2] test_firmware: Install all scripts Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418203808.GQ30543@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox