From: James Hogan <jhogan@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Ralf Baechle" <ralf@linux-mips.org>,
linux-mips@linux-mips.org, "Hauke Mehrtens" <hauke@hauke-m.de>,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/2] MIPS: BCM47XX: Add support for Netgear WNR1000 V3
Date: Wed, 18 Apr 2018 22:23:51 +0100 [thread overview]
Message-ID: <20180418212350.GA16439@saruman> (raw)
In-Reply-To: <20180408205733.9026-1-zajec5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Sun, Apr 08, 2018 at 10:57:32PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This adds support for detecting this model board and registers some LEDs
> and buttons.
>
> There are two uncommon things regarding this device:
> 1) It can use two different "board_id" ID values.
> Unit I have uses "U12H139T00_NETGEAR" value. This magic is also used
> in firmware file header. There are two reports (one from an OpenWrt
> user) of a different "U12H139T50_NETGEAR" magic though.
> 2) Power LEDs share GPIOs with buttons.
> Amber one seems to share GPIO 2 with WPS button and green one seems
> to share GPIO 3 with reset button. It remains unknown how to support
> them and handle buttons at the same time. For that reason they aren't
> added to the list of supported LEDs.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Thanks, both applied for 4.18.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-18 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 20:57 [PATCH 1/2] MIPS: BCM47XX: Add support for Netgear WNR1000 V3 Rafał Miłecki
2018-04-08 20:57 ` [PATCH 2/2] firmware: bcm47xx_nvram: support small (0x6000 B) NVRAM partitions Rafał Miłecki
2018-04-18 21:23 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418212350.GA16439@saruman \
--to=jhogan@kernel.org \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=rafal@milecki.pl \
--cc=ralf@linux-mips.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox