Re: [PATCH 1/2] atomic_ops.rst: Fix wrong example code

Paul E. McKenney
2018-04-19T13:54:42Z

On Thu, Apr 19, 2018 at 05:42:44PM +0900, SeongJae Park wrote:
> Example code snippets for necessary of READ_ONCE() and WRITE_ONCE() has
> an unnecessary line of code and wrong condition. This commit fixes
> them.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>

Good catch!!! I queued and pushed both patches for further review,
thank you!

Thanx, Paul

> ---
> Documentation/core-api/atomic_ops.rst | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/core-api/atomic_ops.rst b/Documentation/core-api/atomic_ops.rst
> index fce929144ccd..4ea4af71e68a 100644
> --- a/Documentation/core-api/atomic_ops.rst
> +++ b/Documentation/core-api/atomic_ops.rst
> @@ -111,7 +111,6 @@ If the compiler can prove that do_something() does not store to the
> variable a, then the compiler is within its rights transforming this to
> the following::
>
> - tmp = a;
> if (a > 0)
> for (;;)
> do_something();
> @@ -119,7 +118,7 @@ the following::
> If you don't want the compiler to do this (and you probably don't), then
> you should use something like the following::
>
> - while (READ_ONCE(a) < 0)
> + while (READ_ONCE(a) > 0)
> do_something();
>
> Alternatively, you could place a barrier() call in the loop.
> --
> 2.13.0
>