From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3169877-1524143438-2-8560997264521271207 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.136', Host='smtp3.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1524143437; b=BZQ+JCfTlSsh7qJISmhEqVEDl5fHHHLUQPpOgvsiS+ac7mR6Om zLUo2xEzot4tRvDJ6whVYtvHDs+DGtG7fSR8j6GFpV4Yu039lrkVeV1Ltm5rTQ6Z /lKtnC6LipdQbkCYpYwW7D8diSULUvuj6MRsURhd/hBi3gfhHskOKskYfXUOvVFX jPFFyjzautP+CgbyHlxG2BDF1hPsi9FLRj1AUMplAaO8OA671baeuENW9xlDtMbG bDwBX3aa5pkrEVwrrZd6yWPhJ7LB+RFucCGAF3c2ot52rRLyS5sCqp9XDBi245A/ k/djsjmLa2uABRcqKh/NxQwxYEZA0Da4Gyxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=fm2; t=1524143437; bh=j7Zg/ uNBKPwMrrpl6yRKT6/rr4turn9pyziBeehvPmc=; b=o56jiB8B7qSphuJ8DS3BI DHtBreRSRw492wFQZl8eShNpJtArhnNFkA6l2M9czdmHITRcZ9cfG3YfVTwGLPD7 ibh1LGAiXSn9vgTeBVKKlYrwNhHH8TP6mZx72SEVhrZ5BPcMsBZPEwPPdXNLLaIt jNFnbejdYbSOhPcslIpwMB2qTl1A+hNctfqGH5LRS65kVByt5fvbbuMsyQAVtBHQ lKL6BfP6E2J0bj/bp1SAh4xLzUQ+YXTsJYfyHJfCys4AIOILM/jUnyEI2YTQwTeA JP/p5/x8ZOxDh3ZKl/kQzjdPMs/Kp+/j1dUGxu7bKSvXa95l13BzKbQTh+8f0QZV g== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=bootlin.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-cm=discussion score=0; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=bootlin.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=bootlin.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-cm=discussion score=0; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=bootlin.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfOgm/Onh3nwzM4/APZAWTvGGsEYJWom478QzfxiLvW0n7TlMdqVOg7JF5v3kmHDvs6VIYS2DhUz+l6pC7h6P84iy1aEtD/01G4dQ0OprxJDPG6E9/mCz GtGbkoVP/czT3gg35M+mJpm/aMMdWmL5nybYwAonD2Mpu2hpcmQzUHv6nR8WKyl5svciipj1XVHTfDSBAIH3X6pDOo85Dmr3kFvdZ6hs7+7D8jPQ2GpLCtNx FNis7+7XM0KH73Oi65MWBA== X-CM-Analysis: v=2.3 cv=NPP7BXyg c=1 sm=1 tr=0 a=FmzrR3azffoSx43hyxYGHg==:117 a=FmzrR3azffoSx43hyxYGHg==:17 a=kj9zAlcOel0A:10 a=Kd1tUaAdevIA:10 a=-uNXE31MpBQA:10 a=jJxKW8Ag-pUA:10 a=P-IC7800AAAA:8 a=DDOyTI_5AAAA:8 a=3-kxKz2tk651-UjX9w4A:9 a=CjuIK1q_8ugA:10 a=d3PnA9EDa4IxuAV0gXij:22 a=_BcfOz0m4U4ohdxiHPKc:22 cc=dsc X-ME-CMScore: 0 X-ME-CMCategory: discussion X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Thu, 19 Apr 2018 15:10:27 +0200 From: Alexandre Belloni To: Christoph Hellwig Subject: Re: [PATCH 26/39] rtc/proc: switch to proc_create_single_data Message-ID: <20180419131027.GC7369@piout.net> References: <20180419124140.9309-1-hch@lst.de> <20180419124140.9309-27-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180419124140.9309-27-hch@lst.de> User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , jfs-discussion@lists.sourceforge.net, devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, Corey Minyard , linux-ide@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Alexander Viro , Jiri Slaby , Andrew Morton , linux-ext4@vger.kernel.org, Alexey Dobriyan , megaraidlinux.pdl@broadcom.com, drbd-dev@lists.linbit.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 19/04/2018 14:41:27+0200, Christoph Hellwig wrote: > And stop trying to get a reference on the submodule, procfs code deals > with release after and unloaded module and thus removed proc entry. > Are you sure about that? The rtc module is not the one adding the procfs file so I'm not sure how the procfs code can handle it. > Signed-off-by: Christoph Hellwig > --- > drivers/rtc/rtc-proc.c | 33 ++------------------------------- > 1 file changed, 2 insertions(+), 31 deletions(-) > > diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c > index 31e7e23cc5be..a9dd9218fae2 100644 > --- a/drivers/rtc/rtc-proc.c > +++ b/drivers/rtc/rtc-proc.c > @@ -107,40 +107,11 @@ static int rtc_proc_show(struct seq_file *seq, void *offset) > return 0; > } > > -static int rtc_proc_open(struct inode *inode, struct file *file) > -{ > - int ret; > - struct rtc_device *rtc = PDE_DATA(inode); > - > - if (!try_module_get(rtc->owner)) > - return -ENODEV; > - > - ret = single_open(file, rtc_proc_show, rtc); > - if (ret) > - module_put(rtc->owner); > - return ret; > -} > - > -static int rtc_proc_release(struct inode *inode, struct file *file) > -{ > - int res = single_release(inode, file); > - struct rtc_device *rtc = PDE_DATA(inode); > - > - module_put(rtc->owner); > - return res; > -} > - > -static const struct file_operations rtc_proc_fops = { > - .open = rtc_proc_open, > - .read = seq_read, > - .llseek = seq_lseek, > - .release = rtc_proc_release, > -}; > - > void rtc_proc_add_device(struct rtc_device *rtc) > { > if (is_rtc_hctosys(rtc)) > - proc_create_data("driver/rtc", 0, NULL, &rtc_proc_fops, rtc); > + proc_create_single_data("driver/rtc", 0, NULL, rtc_proc_show, > + rtc); > } > > void rtc_proc_del_device(struct rtc_device *rtc) > -- > 2.17.0 > -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel