From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753539AbeDSOjF (ORCPT ); Thu, 19 Apr 2018 10:39:05 -0400 Received: from gateway36.websitewelcome.com ([192.185.200.11]:41162 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753162AbeDSOjC (ORCPT ); Thu, 19 Apr 2018 10:39:02 -0400 X-Authority-Reason: nr=8 Date: Thu, 19 Apr 2018 08:53:16 -0500 From: "Gustavo A. R. Silva" To: Masahiro Yamada , Adrian Hunter , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] mmc: sdhci-cadence: fix logically and structurally dead code Message-ID: <20180419135316.GA14790@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.6.211 X-Source-L: No X-Exim-ID: 1f99zx-001dxw-AF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.175.6.211]:39794 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 10 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, the code block inside the for loop will never execute more than once, because the function returns inmediately after the first iteration, hence the execution of the code at the second iteration is structurally dead and, code at line 281: return 0; is never reached. Based on the code comments, it seems that the actual intention is to execute the code inside the for loop twice instead of once. So, fix this issue by removing the return statement inside the for loop and replace the "return 0" with "return ret". Addresses-Coverity-ID: 1468009 ("Logically dead code") Addresses-Coverity-ID: 1468002 ("Structurally dead code") Fixes: 213fae74318b ("mmc: sdhci-cadence: send tune request twice to work around errata") Signed-off-by: Gustavo A. R. Silva --- drivers/mmc/host/sdhci-cadence.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c index bc30d16..facbad8 100644 --- a/drivers/mmc/host/sdhci-cadence.c +++ b/drivers/mmc/host/sdhci-cadence.c @@ -275,10 +275,9 @@ static int sdhci_cdns_set_tune_val(struct sdhci_host *host, unsigned int val) !(tmp & SDHCI_CDNS_HRS06_TUNE_UP), 0, 1); - return ret; } - return 0; + return ret; } static int sdhci_cdns_execute_tuning(struct mmc_host *mmc, u32 opcode) -- 2.7.4