From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753859AbeDTHWc (ORCPT ); Fri, 20 Apr 2018 03:22:32 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35339 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbeDTHWb (ORCPT ); Fri, 20 Apr 2018 03:22:31 -0400 X-Google-Smtp-Source: AIpwx48CC6ZUO/5Kn4deKgNPa80iZ+5FZbYyI3JlUHqMjEfJEXrYj4QIUf7vPcHpWJEl4947romADA== Date: Fri, 20 Apr 2018 09:22:27 +0200 From: Daniel Vetter To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Oleksandr Andrushchenko , "jgross@suse.com" , Artem Mygaiev , Dongwon Kim , "Oleksandr_Andrushchenko@epam.com" , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Paul Durrant , "Potrola, MateuszX" , "daniel.vetter@intel.com" , "xen-devel@lists.xenproject.org" , "boris.ostrovsky@oracle.com" Subject: Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver Message-ID: <20180420072227.GH31310@phenom.ffwll.local> Mail-Followup-To: Roger Pau =?iso-8859-1?Q?Monn=E9?= , Oleksandr Andrushchenko , "jgross@suse.com" , Artem Mygaiev , Dongwon Kim , "Oleksandr_Andrushchenko@epam.com" , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Paul Durrant , "Potrola, MateuszX" , "daniel.vetter@intel.com" , "xen-devel@lists.xenproject.org" , "boris.ostrovsky@oracle.com" References: <20180416192905.GA18096@downor-Z87X-UD5H> <20180417075928.GT31310@phenom.ffwll.local> <20180417205744.GA15930@downor-Z87X-UD5H> <41487acb-a67a-8933-d0c3-702c19b0938e@gmail.com> <20180418073508.ptvntwedczpvl7bx@MacBook-Pro-de-Roger.local> <20180418101058.hyqk3gr3b2ibxswu@MacBook-Pro-de-Roger.local> <7d6710a76b9a42299139d7914358ed52@AMSPEX02CL03.citrite.net> <46489b33-e6fc-b874-6cd4-dbb94c002ef8@gmail.com> <20180418105526.a4qtlhofrn3gubsl@MacBook-Pro-de-Roger.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180418105526.a4qtlhofrn3gubsl@MacBook-Pro-de-Roger.local> X-Operating-System: Linux phenom 4.15.0-1-amd64 User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 18, 2018 at 11:55:26AM +0100, Roger Pau Monné wrote: > On Wed, Apr 18, 2018 at 01:39:35PM +0300, Oleksandr Andrushchenko wrote: > > On 04/18/2018 01:18 PM, Paul Durrant wrote: > > > > -----Original Message----- > > > > From: Xen-devel [mailto:xen-devel-bounces@lists.xenproject.org] On Behalf > > > > Of Roger Pau Monné > > > > Sent: 18 April 2018 11:11 > > > > To: Oleksandr Andrushchenko > > > > Cc: jgross@suse.com; Artem Mygaiev ; > > > > Dongwon Kim ; airlied@linux.ie; > > > > Oleksandr_Andrushchenko@epam.com; linux-kernel@vger.kernel.org; dri- > > > > devel@lists.freedesktop.org; Potrola, MateuszX > > > > ; xen-devel@lists.xenproject.org; > > > > daniel.vetter@intel.com; boris.ostrovsky@oracle.com; Matt Roper > > > > > > > > Subject: Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy > > > > helper DRM driver > > > > > > > > On Wed, Apr 18, 2018 at 11:01:12AM +0300, Oleksandr Andrushchenko > > > > wrote: > > > > > On 04/18/2018 10:35 AM, Roger Pau Monné wrote: > > > > After speaking with Oleksandr on IRC, I think the main usage of the > > > > gntdev extension is to: > > > > > > > > 1. Create a dma-buf from a set of grant references. > > > > 2. Share dma-buf and get a list of grant references. > > > > > > > > I think this set of operations could be broken into: > > > > > > > > 1.1 Map grant references into user-space using the gntdev. > > > > 1.2 Create a dma-buf out of a set of user-space virtual addresses. > > > > > > > > 2.1 Map a dma-buf into user-space. > > > > 2.2 Get grefs out of the user-space addresses where the dma-buf is > > > > mapped. > > > > > > > > So it seems like what's actually missing is a way to: > > > > > > > > - Create a dma-buf from a list of user-space virtual addresses. > > > > - Allow to map a dma-buf into user-space, so it can then be used with > > > > the gntdev. > > > > > > > > I think this is generic enough that it could be implemented by a > > > > device not tied to Xen. AFAICT the hyper_dma guys also wanted > > > > something similar to this. > > Ok, so just to summarize, xen-zcopy/hyper-dmabuf as they are now, > > are no go from your POV? > > My opinion is that there seems to be a more generic way to implement > this, and thus I would prefer that one. > > > Instead, we have to make all that fancy stuff > > with VAs <-> device-X and have that device-X driver live out of drivers/xen > > as it is not a Xen specific driver? > > That would be my preference if feasible, simply because it can be > reused by other use-cases that need to create dma-bufs in user-space. > > In any case I just knew about dma-bufs this morning, there might be > things that I'm missing. See my other reply, I really don't want a generic userspace memory -> dma-buf thing, it doesn't work. Having a xen-specific grant references <-> dma-buf conversion thing (and I'm honestly still not sure whether the dma-buf -> grant renferences is a good idea) seems much more reasonable to me. Imo simplest way forward would be to start out with a grant refs -> dma-buf ioctl, and see how far that gets us. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch