From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755215AbeDTNwT (ORCPT ); Fri, 20 Apr 2018 09:52:19 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46928 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755050AbeDTNwR (ORCPT ); Fri, 20 Apr 2018 09:52:17 -0400 Date: Fri, 20 Apr 2018 15:52:13 +0200 From: Jesper Dangaard Brouer To: Daniel Thompson Cc: Leo Yan , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brouer@redhat.com Subject: Re: [PATCH bpf-next 1/5] samples/bpf: Fix typo in comment Message-ID: <20180420155213.2867fcf5@redhat.com> In-Reply-To: <20180420132116.uswpqniteogfu4zz@holly.lan> References: <1524101646-6544-1-git-send-email-leo.yan@linaro.org> <1524101646-6544-2-git-send-email-leo.yan@linaro.org> <20180420141004.259d7d6f@redhat.com> <20180420132116.uswpqniteogfu4zz@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Apr 2018 14:21:16 +0100 Daniel Thompson wrote: > On Fri, Apr 20, 2018 at 02:10:04PM +0200, Jesper Dangaard Brouer wrote: > > > > On Thu, 19 Apr 2018 09:34:02 +0800 Leo Yan wrote: > > > > > Fix typo by replacing 'iif' with 'if'. > > > > > > Signed-off-by: Leo Yan > > > --- > > > samples/bpf/bpf_load.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c > > > index bebe418..28e4678 100644 > > > --- a/samples/bpf/bpf_load.c > > > +++ b/samples/bpf/bpf_load.c > > > @@ -393,7 +393,7 @@ static int load_elf_maps_section(struct bpf_map_data *maps, int maps_shndx, > > > continue; > > > if (sym[nr_maps].st_shndx != maps_shndx) > > > continue; > > > - /* Only increment iif maps section */ > > > + /* Only increment if maps section */ > > > nr_maps++; > > > } > > > > This was actually not a typo from my side. > > > > With 'iif' I mean 'if and only if' ... but it doesn't matter much. > > I think 'if and only if' is more commonly abbreviated 'iff' isn't it? Ah, yes![1] -- then it *is* actually a typo! - LOL I'm fine with changing this to "if" :-) [1] https://en.wikipedia.org/wiki/If_and_only_if -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer