From: Darren Hart <dvhart@infradead.org>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.
Date: Fri, 20 Apr 2018 14:52:12 -0700 [thread overview]
Message-ID: <20180420215212.GE11546@fury> (raw)
In-Reply-To: <1524246131-17621-1-git-send-email-mario.limonciello@dell.com>
On Fri, Apr 20, 2018 at 12:42:11PM -0500, Mario Limonciello wrote:
> As reported by Randy Dunlap:
> >> WARNING: unmet direct dependencies detected for DELL_SMBIOS
> >> Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> >> && (DCDBAS [=m] ||
> >> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
> >> Selected by [y]:
> >> - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y]
> >> && DMI [=y]
> >> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] ||
> >> ACPI_VIDEO [=n]=n)
> >> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y]
> >>
>
> Right now it's possible to set dell laptop to compile in but this
> causes dell-smbios to compile in which breaks if dcdbas is a module.
>
> Dell laptop shouldn't select dell-smbios anymore, but depend on it.
Ugh. Indeed.
One of the goals of the previous maelstrom of dell* kconfig depencency
changes was to make it so DELL_LAPTOP was visible without having to
toggle DELL_SMBIOS*. But, having "select DELL_SMBIOS" avoids the
dependency check causing this failure (I'm surprised and dismayed this
made it through all the config permutation testing this saw).
I'll apply this patch, and I guess it should go to stable, and for the
next version I think it's time for a new "CONFIG DELL_EXTRAS" which will
allow us to default DELL_SMBIOS to y and make the menu more consistent.
Thank you for the catch. Grrrrrr :-(
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2018-04-20 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 17:42 [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain Mario Limonciello
2018-04-20 17:53 ` Randy Dunlap
2018-04-20 17:55 ` Mario.Limonciello
2018-04-20 21:52 ` Darren Hart
2018-04-20 21:52 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420215212.GE11546@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox