From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4/qTli+IHZR/KngcjhE6GFWcPZVDwRSffthJji+FrvFAS4JzRiV0RRSvzwNOA21GFPaJ2Oa ARC-Seal: i=1; a=rsa-sha256; t=1524405634; cv=none; d=google.com; s=arc-20160816; b=j1gwYRbgjOWgsNeaJZnCtzI7IXRb2LFpNIe6CzgzBqKPjrtTx7e95IUWdhXVZNTA6Z r6j0ELJlefjvvs4pcuw3maPHXSyPGKMvekfCnbyhqAPGvMdDfdxPg3lUDZtV23SnamIl +13L8H86rJqSNbmV3DUs8ZO9Mpxih7YFvAT8jBWmNc5YaJdJadqyYg2uonhaehP4Azll yy0ojjVHaALJ56WYNeCkzi4PXnEmsXeqlK0OFylu2SqAHyz1O7RSogZ+Z+fenxNK4EAL kKVVK7AM69beeHp2B35JagfafNt+52e7eNDK/zyAs5nMlkAsMJjOjanlHgX6H748TF2H R5zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=8PjezgWglOVfBiygrLYEGbIiUSY/CVqV4UPVt0xNsZ8=; b=gUDZxj3yi7CElV88oQRNMaYF/lT/6+a5ZIWICzv4MxqMaA+19fB9iPH6brnRmSY7Eh 4zc9Xael56pZYecMTGUDhDB64abEoUQ54tJQEQCJ7gEehWMg0RA0O/Z/rse/iwmWFY12 KTKVe39yaTz5Xj4o13Qbf7sgHRWhDefw0q2UUco2GqI2sd1+KM9mOSMbEJhfgeLNkUcc Xz0sjkSW3FiKXENMa6VUmPz4Kf6WlSWDgE+tFLoiV6LT40SE4tNjmxSCidFUkSdIi6Nw VneFbQ66u1jJ7+wIpITN8ePjtHZ991aBwn7GmuSVkpZeqIJAjhxMaeS9wkXR32zXWamv NIiA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sinan Kaya , Bjorn Helgaas Subject: [PATCH 4.16 138/196] PCI: Mark Broadcom HT1100 and HT2000 Root Port Extended Tags as broken Date: Sun, 22 Apr 2018 15:52:38 +0200 Message-Id: <20180422135111.384433749@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180422135104.278511750@linuxfoundation.org> References: <20180422135104.278511750@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598455163035819770?= X-GMAIL-MSGID: =?utf-8?q?1598455163035819770?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sinan Kaya commit 1b30dfd376e28e7f37eda5e2033f6823cdda222b upstream. Per PCIe r3.1, sec 2.2.6.2 and 7.8.4, a Requester may not use 8-bit Tags unless its Extended Tag Field Enable is set, but all Receivers/Completers must handle 8-bit Tags correctly regardless of their Extended Tag Field Enable. Some devices do not handle 8-bit Tags as Completers, so add a quirk for them. If we find such a device, we disable Extended Tags for the entire hierarchy to make peer-to-peer DMA possible. The Broadcom HT1100/HT2000/HT2100 seems to have issues with handling 8-bit tags. Mark it as broken. This fixes Xorg hangs and unresponsive keyboards with errors like this: radeon 0000:06:00.0: GPU lockup (current fence id 0x000000000000000e last fence id 0x0000000000000 [drm:r600_ring_test [radeon]] *ERROR* radeon: ring 0 test failed (scratch(0x8504)=0xCAFEDEAD) [drm:r600_resume [radeon]] *ERROR* r600 startup failed on resume Fixes: 60db3a4d8cc9 ("PCI: Enable PCIe Extended Tags if supported") Link: https://bugzilla.kernel.org/show_bug.cgi?id=196197 Signed-off-by: Sinan Kaya Signed-off-by: Bjorn Helgaas CC: stable@vger.kernel.org # v4.11: 62ce94a7a5a5 PCI: Mark Broadcom HT2100 Root Port Extended Tags as broken CC: stable@vger.kernel.org # v4.11 Signed-off-by: Greg Kroah-Hartman --- drivers/pci/quirks.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4815,9 +4815,13 @@ static void quirk_no_ext_tags(struct pci pci_walk_bus(bridge->bus, pci_configure_extended_tags, NULL); } +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0132, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0140, quirk_no_ext_tags); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0141, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0142, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0144, quirk_no_ext_tags); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0420, quirk_no_ext_tags); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0422, quirk_no_ext_tags); #ifdef CONFIG_PCI_ATS /*