From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4/pD28pIefLTKrQlL/gBu+C/gixLym9iJNrgmTeyPT+VZF5eriVUPLMIXjPfjtJCASbOPIg ARC-Seal: i=1; a=rsa-sha256; t=1524406311; cv=none; d=google.com; s=arc-20160816; b=gYKYmRvhQiopl7gWTGEh9hetT/+4Cu95uhObAWZr6udB343gcOZmx7Vu4L38vHULgd 0Eonrt5J4jtDnn3p6z6uKjEn6mQBo6/hjS9q/ExpOjyqeJ6hZZpM4afsQWzRHiErDGdB WPk4wCQob7bNLE6QnDbCHyeCDomu9MJFgUDtYKbcX/bv2MsZkP1rt2MKwozFtFewZVvR qwWlwixZAzazIR0UFXo1EFokOTklZzHas+2PG0VkvWYQ1anqCgNiQaKC7xpVcwzCVLWa 6DN5Hvq4+Ai/+pdwVxkY3QInHWCX6d4I/2S/VOCJlvsV+DCmmKfUXLFN2FjGAE7YNXxy ijiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=/6JvijqJ6hqlhieSfer6+0WzOQCAJcVTMdGX7crE7so=; b=RaQkg3oMoNqfPRYXItBafE6JsoRd6dlYUzZWmnCAhsJv4rjdV8Hy26Vk3hjbaKcYuj kMwG6TBau/vSUUy42Gh3I+bbppM2gowuoYS3qTH2tln59913vTYo9btvTuvUqHlJkG/2 qYbO+NLnwmkTq3A3j8epW753bivIVNtquk7u8Vk3ddGq4dgH88MzChTUBbRQRn2SICw3 GMwS44mpMGXAxTS9cC/mNdJRTDPo6kbnZ3wJm+GkobFv2H4MBHkOoRNeZ9hzdFYSA4yv 0RcLEq0eNAF98gc5X1J54jM/xBUstSGs7jUTgxM6+PL2uA3n36lRY8MhrHabTOuzs91v 0g9g== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Randy Dunlap , syzbot+6bd77b88c1977c03f584@syzkaller.appspotmail.com, Jeff Mahoney , Alexander Viro , Jan Kara , Andrew Morton , Linus Torvalds Subject: [PATCH 4.9 06/95] fs/reiserfs/journal.c: add missing resierfs_warning() arg Date: Sun, 22 Apr 2018 15:52:35 +0200 Message-Id: <20180422135210.692204982@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180422135210.432103639@linuxfoundation.org> References: <20180422135210.432103639@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598454902575626953?= X-GMAIL-MSGID: =?utf-8?q?1598455872056121530?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Morton commit 9ad553abe66f8be3f4755e9fa0a6ba137ce76341 upstream. One use of the reiserfs_warning() macro in journal_init_dev() is missing a parameter, causing the following warning: REISERFS warning (device loop0): journal_init_dev: Cannot open '%s': %i journal_init_dev: This also causes a WARN_ONCE() warning in the vsprintf code, and then a panic if panic_on_warn is set. Please remove unsupported %/ in format string WARNING: CPU: 1 PID: 4480 at lib/vsprintf.c:2138 format_decode+0x77f/0x830 lib/vsprintf.c:2138 Kernel panic - not syncing: panic_on_warn set ... Just add another string argument to the macro invocation. Addresses https://syzkaller.appspot.com/bug?id=0627d4551fdc39bf1ef5d82cd9eef587047f7718 Link: http://lkml.kernel.org/r/d678ebe1-6f54-8090-df4c-b9affad62293@infradead.org Signed-off-by: Randy Dunlap Reported-by: Tested-by: Randy Dunlap Acked-by: Jeff Mahoney Cc: Alexander Viro Cc: Jan Kara Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- fs/reiserfs/journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/reiserfs/journal.c +++ b/fs/reiserfs/journal.c @@ -2640,7 +2640,7 @@ static int journal_init_dev(struct super if (IS_ERR(journal->j_dev_bd)) { result = PTR_ERR(journal->j_dev_bd); journal->j_dev_bd = NULL; - reiserfs_warning(super, + reiserfs_warning(super, "sh-457", "journal_init_dev: Cannot open '%s': %i", jdev_name, result); return result;