public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joey Pabalinas <joeypabalinas@gmail.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Jiri Slaby <jslaby@suse.cz>, Tomasz Kramkowsk <tk@the-tk.com>
Subject: Re: [PATCH v2 1/4] tty/nozomi: cleanup DUMP() macro
Date: Mon, 23 Apr 2018 10:51:31 +0200	[thread overview]
Message-ID: <20180423085131.GA3894@kroah.com> (raw)
In-Reply-To: <20180324112732.29424-2-joeypabalinas@gmail.com>

On Sat, Mar 24, 2018 at 01:27:29AM -1000, Joey Pabalinas wrote:
> Replace snprint() with strscpy() and use max_t() instead of
> the conditional operator.
> 
> Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
> 
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 

Something is really odd here, look at what is in your changelog above :(

Same for all of these patches.  Can you please fix up and resend?

thanks,

greg k-h

  reply	other threads:[~2018-04-23  8:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-24 11:27 [PATCH v2 0/4] tty/nozomi: general module cleanup Joey Pabalinas
2018-03-24 11:27 ` [PATCH v2 1/4] tty/nozomi: cleanup DUMP() macro Joey Pabalinas
2018-04-23  8:51   ` Greg Kroah-Hartman [this message]
2018-04-23 10:40     ` Joey Pabalinas
2018-03-24 11:27 ` [PATCH v2 2/4] tty/nozomi: fix inconsistent indentation Joey Pabalinas
2018-03-24 11:27 ` [PATCH v2 3/4] tty/nozomi: improve code readability and style Joey Pabalinas
2018-03-24 11:27 ` [PATCH v2 4/4] tty/nozomi: refactor conditional statements Joey Pabalinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180423085131.GA3894@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=joeypabalinas@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tk@the-tk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox