From: Greg KH <gregkh@linuxfoundation.org>
To: Quytelda Kahja <quytelda@tamalin.org>
Cc: devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, wsa@the-dreams.de
Subject: Re: [PATCH v2 75/75] staging: ks7010: Replace memcpy() with ether_addr_copy().
Date: Mon, 23 Apr 2018 14:20:17 +0200 [thread overview]
Message-ID: <20180423122017.GA30910@kroah.com> (raw)
In-Reply-To: <20180331060855.9452-75-quytelda@tamalin.org>
On Fri, Mar 30, 2018 at 11:08:55PM -0700, Quytelda Kahja wrote:
> ether_addr_copy() is the function for copying a hardware address,
> so replace the manual memcpy() operation with ether_addr_copy().
>
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
> ---
> drivers/staging/ks7010/ks_hostif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index b5a2ba702dec..a461dd568d28 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -522,7 +522,7 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
> case DOT11_MAC_ADDRESS:
> /* MAC address */
> hostif_sme_enqueue(priv, SME_GET_MAC_ADDRESS);
> - memcpy(dev->dev_addr, priv->rxp, ETH_ALEN);
> + ether_addr_copy(dev->dev_addr, priv->rxp);
> priv->mac_address_valid = true;
> netdev_info(dev, "MAC ADDRESS = %pM\n", dev->dev_addr);
> break;
> --
> 2.16.3
Not all of these patches applied. Can you please rebase and resend the
remaining ones?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-04-23 12:20 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFLvi23=E6QubTGX0=cHjbJGB=Vx5OJ7d16E2R4HZTscmJuuSw@mail.gmail.com>
2018-03-31 6:07 ` [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 02/75] staging: ks7010: Remove trailing _t from 'struct wpa_suite_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 03/75] staging: ks7010: Remove trailing _t from 'struct rsn_mode_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 04/75] staging: ks7010: Remove trailing _t from 'struct pmk_cache_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 05/75] staging: ks7010: Remove trailing _t from 'struct hostif_data_request_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 06/75] staging: ks7010: Remove unused 'struct hostif_data_indication_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 07/75] staging: ks7010: Remove trailing _t from 'struct channel_list_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 08/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_get_request_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 09/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_value_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 10/75] staging: ks7010: Remove unused 'struct hostif_mib_get_confirm_t' Quytelda Kahja
2018-04-23 12:13 ` Greg KH
2018-03-31 6:07 ` [PATCH v2 11/75] staging: ks7010: Remove trailing _t from 'struct hostif_mib_set_request_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 12/75] staging: ks7010: Remove unused 'struct hostif_mib_set_confirm_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 13/75] staging: ks7010: Remove trailing _t from 'struct hostif_power_mgmt_request_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 14/75] staging: ks7010: Remove unused 'struct hostif_power_mgmt_confirm_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 15/75] staging: ks7010: Remove trailing _t from 'struct hostif_start_request_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 16/75] staging: ks7010: Remove unused 'struct hostif_start_confirm_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 17/75] staging: ks7010: Remove trailing _t from 'struct ssid_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 18/75] staging: ks7010: Remove trailing _t from 'struct rate_set8_t' Quytelda Kahja
2018-03-31 6:07 ` [PATCH v2 19/75] staging: ks7010: Remove trailing _t from 'struct fh_parms_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 20/75] staging: ks7010: Remove trailing _t from 'struct ds_parms_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 21/75] staging: ks7010: Remove trailing _t from 'struct cf_parms_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 22/75] staging: ks7010: Remove trailing _t from 'struct ibss_parms_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 23/75] staging: ks7010: Remove unused 'struct rsn_t' Quytelda Kahja
2018-04-23 12:14 ` Greg KH
2018-03-31 6:08 ` [PATCH v2 24/75] staging: ks7010: Remove trailing _t from 'struct erp_params_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 25/75] staging: ks7010: Remove trailing _t from 'struct rate_set16_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 26/75] staging: ks7010: Remove trailing _t from 'struct ap_info_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 27/75] staging: ks7010: Remove trailing _t from 'struct link_ap_info_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 28/75] staging: ks7010: Remove unused 'struct hostif_connect_indication_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 29/75] staging: ks7010: Remove trailing _t from 'struct hostif_stop_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 30/75] staging: ks7010: Remove unused 'struct hostif_stop_confirm_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 31/75] staging: ks7010: Remove trailing _t from 'struct hostif_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 32/75] staging: ks7010: Remove trailing _t from 'struct hostif_ps_adhoc_set_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 33/75] staging: ks7010: Remove unused 'struct hostif_ps_adhoc_set_confirm_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 34/75] staging: ks7010: Remove trailing _t from 'struct hostif_infrastructure_set_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 35/75] staging: ks7010: Remove unused 'struct hostif_infrastructure_set_confirm_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 36/75] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 37/75] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set2_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 38/75] staging: ks7010: Remove unused 'struct hostif_adhoc_set_confirm_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 39/75] staging: ks7010: Remove unused 'struct last_associate_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 40/75] staging: ks7010: Remove trailing _t from 'struct association_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 41/75] staging: ks7010: Remove trailing _t from 'struct association_response_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 42/75] staging: ks7010: Remove unused 'struct hostif_associate_indication_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 43/75] staging: ks7010: Remove trailing _t from 'struct hostif_bss_scan_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 44/75] staging: ks7010: Remove unused 'struct hostif_bss_scan_confirm_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 45/75] staging: ks7010: Remove trailing _t from 'struct hostif_phy_information_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 46/75] staging: ks7010: Remove unused 'struct hostif_phy_information_confirm_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 47/75] staging: ks7010: Remove trailing _t from 'struct hostif_sleep_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 48/75] staging: ks7010: Remove unused 'struct hostif_sleep_confirm_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 49/75] staging: ks7010: Remove trailing _t from 'struct hostif_mic_failure_request_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 50/75] staging: ks7010: Remove unused 'struct hostif_mic_failure_confirm_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 51/75] staging: ks7010: Remove trailing _t from 'struct hostt_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 52/75] staging: ks7010: Remove trailing _t from 'struct rsn_ie_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 53/75] staging: ks7010: Remove trailing _t from 'struct wps_ie_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 54/75] staging: ks7010: Remove trailing _t from 'struct local_ap_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 55/75] staging: ks7010: Remove trailing _t from 'struct local_aplist_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 56/75] staging: ks7010: Remove trailing _t from 'struct local_gain_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 57/75] staging: ks7010: Remove trailing _t from 'struct local_eeprom_sum_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 58/75] staging: ks7010: Remove trailing _t from 'struct power_save_status_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 59/75] staging: ks7010: Remove trailing _t from 'struct sleep_status_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 60/75] staging: ks7010: Remove trailing _t from 'struct scan_ext_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 61/75] staging: ks7010: Remove trailing _t from 'struct wpa_key_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 62/75] staging: ks7010: Remove trailing _t from 'struct mic_failure_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 63/75] staging: ks7010: Remove trailing _t from 'struct wpa_status_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 64/75] staging: ks7010: Remove trailing _t from 'struct pmk_list_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 65/75] staging: ks7010: Remove trailing _t from 'struct pmk_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 66/75] staging: ks7010: Remove trailing _t from 'struct wps_status_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 67/75] staging: ks7010: Remove trailing _t from 'struct michael_mic_t' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 68/75] staging: ks7010: Replace manual array copy with ether_addr_copy() Quytelda Kahja
2018-03-31 9:14 ` Dan Carpenter
2018-03-31 6:08 ` [PATCH v2 69/75] staging: ks7010: Remove extra blank line between functions Quytelda Kahja
2018-03-31 8:43 ` Dan Carpenter
2018-03-31 6:08 ` [PATCH v2 70/75] staging: ks7010: Rename ks_wlan_set_multicast_list() Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 71/75] staging: ks7010: Remove dummy address set Quytelda Kahja
2018-03-31 8:46 ` Dan Carpenter
2018-04-03 1:43 ` Dan Carpenter
2018-03-31 6:08 ` [PATCH v2 72/75] staging: ks7010: Change 'device_open_status' to a bool Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 73/75] staging: ks7010: Remove unnecessary casts in 'struct ks_wlan_handler_def' Quytelda Kahja
2018-03-31 6:08 ` [PATCH v2 74/75] staging: ks7010: Replace memcmp() with ether_addr_equal() Quytelda Kahja
2018-04-03 7:14 ` Dan Carpenter
2018-03-31 6:08 ` [PATCH v2 75/75] staging: ks7010: Replace memcpy() with ether_addr_copy() Quytelda Kahja
2018-04-23 12:20 ` Greg KH [this message]
2018-03-31 6:36 ` [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes Joe Perches
2018-03-31 8:41 ` Dan Carpenter
2018-03-31 14:12 ` Joe Perches
2018-04-02 11:45 ` Dan Carpenter
2018-04-02 14:57 ` Joe Perches
2018-04-02 18:09 ` Quytelda Kahja
2018-04-03 7:17 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423122017.GA30910@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quytelda@tamalin.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox