From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755483AbeDWOQg (ORCPT ); Mon, 23 Apr 2018 10:16:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:37446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755184AbeDWOQc (ORCPT ); Mon, 23 Apr 2018 10:16:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2849B217A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 23 Apr 2018 11:16:29 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Ingo Molnar , Namhyung Kim , David Ahern , Alexander Shishkin , Peter Zijlstra Subject: Re: [PATCH 3/9] perf stat: Keep the / modifier separator in fallback Message-ID: <20180423141629.GB30324@kernel.org> References: <20180423090823.32309-1-jolsa@kernel.org> <20180423090823.32309-4-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180423090823.32309-4-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Apr 23, 2018 at 11:08:17AM +0200, Jiri Olsa escreveu: > The perf stat fallback for EACCES error sets exclude_kernel > for event and repeats the open. In addition, it also changes > the name of the event to reflect that change by adding the > 'u' modifier. > > But it does not take into account the '/' separator, so the > event name can end up mangled, like: > (note the '/:' characters) > > $ perf stat -e cpu/cpu-cycles/ kill > ... > 386,832 cpu/cpu-cycles/:u > > Adding the code to check on the '/' separatos and set > following event name: > > $ perf stat -e cpu/cpu-cycles/ kill > ... > 388,548 cpu/cpu-cycles/u Thanks, tested, reproduced and applied to perf/urgent - Arnaldo