From: subhra mazumdar <subhra.mazumdar@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@redhat.com,
daniel.lezcano@linaro.org, steven.sistare@oracle.com,
dhaval.giani@oracle.com, rohit.k.jain@oracle.com,
subhra.mazumdar@oracle.com
Subject: [PATCH 3/3] sched: limit cpu search and rotate search window for scalability
Date: Mon, 23 Apr 2018 17:41:16 -0700 [thread overview]
Message-ID: <20180424004116.28151-4-subhra.mazumdar@oracle.com> (raw)
In-Reply-To: <20180424004116.28151-1-subhra.mazumdar@oracle.com>
Lower the lower limit of idle cpu search in select_idle_cpu() and also put
an upper limit. This helps in scalability of the search by restricting the
search window. Also rotating the search window with help of next_cpu
ensures any idle cpu is eventually found in case of high load.
Signed-off-by: subhra mazumdar <subhra.mazumdar@oracle.com>
---
kernel/sched/fair.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d1d4769..62d585b 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6279,7 +6279,7 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t
u64 avg_cost, avg_idle;
u64 time, cost;
s64 delta;
- int cpu, nr = INT_MAX;
+ int cpu, target_tmp, nr = INT_MAX;
this_sd = rcu_dereference(*this_cpu_ptr(&sd_llc));
if (!this_sd)
@@ -6297,15 +6297,24 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t
if (sched_feat(SIS_PROP)) {
u64 span_avg = sd->span_weight * avg_idle;
- if (span_avg > 4*avg_cost)
+ if (span_avg > 2*avg_cost) {
nr = div_u64(span_avg, avg_cost);
- else
- nr = 4;
+ if (nr > 4)
+ nr = 4;
+ } else {
+ nr = 2;
+ }
}
+ if (per_cpu(next_cpu, target) != -1)
+ target_tmp = per_cpu(next_cpu, target);
+ else
+ target_tmp = target;
+
time = local_clock();
- for_each_cpu_wrap(cpu, sched_domain_span(sd), target) {
+ for_each_cpu_wrap(cpu, sched_domain_span(sd), target_tmp) {
+ per_cpu(next_cpu, target) = cpu;
if (!--nr)
return -1;
if (!cpumask_test_cpu(cpu, &p->cpus_allowed))
--
2.9.3
next prev parent reply other threads:[~2018-04-24 0:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 0:41 [RFC/RFT PATCH 0/3] Improve scheduler scalability for fast path subhra mazumdar
2018-04-24 0:41 ` [PATCH 1/3] sched: remove select_idle_core() for scalability subhra mazumdar
2018-04-24 12:46 ` Peter Zijlstra
2018-04-24 21:45 ` Subhra Mazumdar
2018-04-25 17:49 ` Peter Zijlstra
2018-04-30 23:38 ` Subhra Mazumdar
2018-05-01 18:03 ` Peter Zijlstra
2018-05-02 21:58 ` Subhra Mazumdar
2018-05-04 18:51 ` Subhra Mazumdar
2018-05-29 21:36 ` Peter Zijlstra
2018-05-30 22:08 ` Subhra Mazumdar
2018-05-31 9:26 ` Peter Zijlstra
2018-04-24 0:41 ` [PATCH 2/3] sched: introduce per-cpu var next_cpu to track search limit subhra mazumdar
2018-04-24 12:47 ` Peter Zijlstra
2018-04-24 22:39 ` Subhra Mazumdar
2018-04-24 0:41 ` subhra mazumdar [this message]
2018-04-24 12:48 ` [PATCH 3/3] sched: limit cpu search and rotate search window for scalability Peter Zijlstra
2018-04-24 22:43 ` Subhra Mazumdar
2018-04-24 12:48 ` Peter Zijlstra
2018-04-24 22:48 ` Subhra Mazumdar
2018-04-24 12:53 ` Peter Zijlstra
2018-04-25 0:10 ` Subhra Mazumdar
2018-04-25 15:36 ` Peter Zijlstra
2018-04-25 18:01 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424004116.28151-4-subhra.mazumdar@oracle.com \
--to=subhra.mazumdar@oracle.com \
--cc=daniel.lezcano@linaro.org \
--cc=dhaval.giani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rohit.k.jain@oracle.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox