Re: [PATCH 5/5] procfs: share fd/fdinfo with thread group leader when files are shared

kbuild test robot
2018-04-24T15:42:22Z

Hi Jeff,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/jeffm-suse-com/procfs-reduce-duplication-by-using-symlinks/20180424-203620
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__

sparse warnings: (new ones prefixed by >>)

fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:285:34: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:331:42: sparse: expression using sizeof(void)
fs/proc/base.c:834:32: sparse: expression using sizeof(void)
fs/proc/base.c:950:27: sparse: expression using sizeof(void)
fs/proc/base.c:951:28: sparse: expression using sizeof(void)
fs/proc/base.c:951:28: sparse: expression using sizeof(void)
fs/proc/base.c:2085:25: sparse: cast to restricted fmode_t
fs/proc/base.c:2140:42: sparse: cast from restricted fmode_t
fs/proc/base.c:2243:48: sparse: cast from restricted fmode_t
>> fs/proc/base.c:3568:32: sparse: symbol 'proc_pid_files_link_dentry_operations' was not declared. Should it be static?
fs/proc/base.c:1078:36: sparse: context imbalance in '__set_oom_adj' - unexpected unlock
fs/proc/base.c:2271:13: sparse: context imbalance in 'timers_start' - wrong count at exit
fs/proc/base.c:2297:36: sparse: context imbalance in 'timers_stop' - unexpected unlock

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation