From: Alexey Dobriyan <adobriyan@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: "Joel Fernandes (Google)" <joel.opensrc@gmail.com>,
Waiman Long <longman@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
rdunlap@infradead.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] proc/stat: Separate out individual irq counts into /proc/stat_irqs
Date: Tue, 24 Apr 2018 09:18:59 +0300 [thread overview]
Message-ID: <20180424061859.GA16181@avx2> (raw)
In-Reply-To: <alpine.DEB.2.21.1804232249380.82340@chino.kir.corp.google.com>
On Mon, Apr 23, 2018 at 10:54:18PM -0700, David Rientjes wrote:
> On Sat, 21 Apr 2018, Alexey Dobriyan wrote:
>
> > > On Thu, Apr 19, 2018 at 04:23:02PM -0700, Joel Fernandes (Google) wrote:
> > > > Can we not just remove per-IRQ stats from /proc/stat (since I gather
> > > > from this discussion it isn't scalable), and just have applications
> > > > that need per-IRQ stats use /proc/interrupts ?
> > >
> > > If you can prove noone is using them in /proc/stat...
> >
> > And you can't even stick WARN into /proc/stat to find out.
> >
>
> FWIW, removing per irq counts from /proc/stat would break some of our
> scripts. We could adapt to that, but everybody else would have to as
> well, so I'm afraid it's not going to be possible.
Excellent!
> It would probably be better to extract out the stats that you're actually
> interested in to a new file.
This is the worst scenario. Individual IRQ stats are going to live in 2 places.
And /proc/stat still would be slow.
next prev parent reply other threads:[~2018-04-24 6:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 19:08 [PATCH] proc/stat: Separate out individual irq counts into /proc/stat_irqs Alexey Dobriyan
2018-04-19 19:28 ` Waiman Long
2018-04-19 19:55 ` Alexey Dobriyan
[not found] ` <eb7c1569-e445-5cbb-6d10-2694b625232a@redhat.com>
2018-04-19 20:39 ` Alexey Dobriyan
2018-04-19 20:58 ` Waiman Long
2018-04-19 23:23 ` Joel Fernandes (Google)
2018-04-21 20:34 ` Alexey Dobriyan
2018-04-21 20:36 ` Alexey Dobriyan
2018-04-24 5:54 ` David Rientjes
2018-04-24 6:18 ` Alexey Dobriyan [this message]
2018-05-02 0:02 ` Andrew Morton
2018-04-19 21:05 ` Waiman Long
-- strict thread matches above, loose matches on Subject: below --
2018-04-19 17:09 Waiman Long
2018-04-19 17:38 ` Randy Dunlap
2018-04-19 18:44 ` Waiman Long
2018-04-19 19:43 ` Andrew Morton
2018-04-19 19:57 ` Waiman Long
2018-04-19 20:02 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424061859.GA16181@avx2 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=joel.opensrc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox