public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Andy Lutomirski <luto@kernel.org>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] ftrace/x86: Fix arch_syscall_match_sym_name for x86_64
Date: Tue, 24 Apr 2018 17:08:20 +0200	[thread overview]
Message-ID: <20180424150820.GA3396@krava> (raw)
In-Reply-To: <20180424103358.3e8efe6e@gandalf.local.home>

On Tue, Apr 24, 2018 at 10:33:58AM -0400, Steven Rostedt wrote:
> On Tue, 24 Apr 2018 12:17:38 +0200
> Jiri Olsa <jolsa@kernel.org> wrote:
> 
> > Recent commit changed the name prefix of syscalls
> > for x86_64 (check the 'Fixes:' for commit number).
> > 
> > The names switch from "sys_" prefix to ""__x64_sys_",
> > which made the default matching function always fail.
> > 
> > Consequently the ftrace syscall __init code could not
> > match any syscall metadata so the "syscall" events
> > vanished. This fix returns them back.
> > 
> 
> Hi Jiri,
> 
> I already fixed it and it's queued it my tree. I'm waiting for some
> other patches that are waiting for review so I can start testing and
> push to Linus.
> 
> Also, this was half the fix, the total fix is here:

yep, that's why I enclosed it to CONFIG_X86_64 ;-)

> 
>   http://lkml.kernel.org/r/20180418114509.5a76847d@gandalf.local.home

after long time I needed 'syscalls' events and couldn't believe my eyes ;-)

> 
> I think I'm done waiting, I'll start testing and get my queue out. If
> the other patches don't get the proper acks, I'm not taking them.

cool, I'll stick with my change for now and rebase when it's in

thanks,
jirka

      reply	other threads:[~2018-04-24 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 10:17 [PATCH] ftrace/x86: Fix arch_syscall_match_sym_name for x86_64 Jiri Olsa
2018-04-24 14:33 ` Steven Rostedt
2018-04-24 15:08   ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424150820.GA3396@krava \
    --to=jolsa@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox