From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
Arnd Bergmann <arnd@arndb.de>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 5/7] gnss: add driver for u-blox receivers
Date: Tue, 24 Apr 2018 18:34:56 +0200 [thread overview]
Message-ID: <20180424163458.11947-6-johan@kernel.org> (raw)
In-Reply-To: <20180424163458.11947-1-johan@kernel.org>
Add driver for serial-connected u-blox GNSS receivers.
Note that the driver uses the generic GNSS serial implementation and
therefore essentially only manages power abstracted into three power
states: ACTIVE, STANDBY, and OFF.
For u-blox receivers with a single supply and no enable-gpios, this
simply means that the main supply is disabled in STANDBY and OFF.
Note that timepulse-support is not yet implemented.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/gnss/Kconfig | 13 +++++
drivers/gnss/Makefile | 3 +
drivers/gnss/ubx.c | 133 ++++++++++++++++++++++++++++++++++++++++++
3 files changed, 149 insertions(+)
create mode 100644 drivers/gnss/ubx.c
diff --git a/drivers/gnss/Kconfig b/drivers/gnss/Kconfig
index f8ee54f99a8d..784b8c0367d9 100644
--- a/drivers/gnss/Kconfig
+++ b/drivers/gnss/Kconfig
@@ -15,4 +15,17 @@ if GNSS
config GNSS_SERIAL
tristate
+config GNSS_UBX_SERIAL
+ tristate "u-blox GNSS receiver support"
+ depends on SERIAL_DEV_BUS
+ select GNSS_SERIAL
+ ---help---
+ Say Y here if you have a u-blox GNSS receiver which uses a serial
+ interface.
+
+ To compile this driver as a module, choose M here: the module will
+ be called gnss-ubx.
+
+ If unsure, say N.
+
endif # GNSS
diff --git a/drivers/gnss/Makefile b/drivers/gnss/Makefile
index 171aba71684d..d9295b20b7bc 100644
--- a/drivers/gnss/Makefile
+++ b/drivers/gnss/Makefile
@@ -8,3 +8,6 @@ gnss-y := core.o
obj-$(CONFIG_GNSS_SERIAL) += gnss-serial.o
gnss-serial-y := serial.o
+
+obj-$(CONFIG_GNSS_UBX_SERIAL) += gnss-ubx.o
+gnss-ubx-y := ubx.o
diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c
new file mode 100644
index 000000000000..2f2f00202b5b
--- /dev/null
+++ b/drivers/gnss/ubx.c
@@ -0,0 +1,133 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * u-blox GNSS receiver driver
+ *
+ * Copyright (C) 2018 Johan Hovold <johan@kernel.org>
+ */
+
+#include <linux/errno.h>
+#include <linux/gnss.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/regulator/consumer.h>
+#include <linux/serdev.h>
+
+#include "serial.h"
+
+struct ubx_data {
+ struct regulator *vcc;
+};
+
+static int ubx_set_active(struct gnss_serial *gserial)
+{
+ struct ubx_data *data = gnss_serial_get_drvdata(gserial);
+ int ret;
+
+ dev_dbg(&gserial->serdev->dev, "%s\n", __func__);
+
+ ret = regulator_enable(data->vcc);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+static int ubx_set_standby(struct gnss_serial *gserial)
+{
+ struct ubx_data *data = gnss_serial_get_drvdata(gserial);
+ int ret;
+
+ dev_dbg(&gserial->serdev->dev, "%s\n", __func__);
+
+ ret = regulator_disable(data->vcc);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+static int
+ubx_set_power(struct gnss_serial *gserial, enum gnss_serial_pm_state state)
+{
+ switch (state) {
+ case GNSS_SERIAL_ACTIVE:
+ return ubx_set_active(gserial);
+ case GNSS_SERIAL_OFF:
+ case GNSS_SERIAL_STANDBY:
+ return ubx_set_standby(gserial);
+ }
+
+ return -EINVAL;
+}
+
+const struct gnss_serial_ops ubx_gserial_ops = {
+ .set_power = ubx_set_power,
+};
+
+static int ubx_probe(struct serdev_device *serdev)
+{
+ struct gnss_serial *gserial;
+ struct ubx_data *data;
+ int ret;
+
+ gserial = gnss_serial_allocate(serdev, sizeof(*data));
+ if (IS_ERR(gserial)) {
+ ret = PTR_ERR(gserial);
+ return ret;
+ }
+
+ gserial->ops = &ubx_gserial_ops;
+
+ data = gnss_serial_get_drvdata(gserial);
+
+ data->vcc = devm_regulator_get(&serdev->dev, "vcc");
+ if (IS_ERR(data->vcc)) {
+ ret = PTR_ERR(data->vcc);
+ goto err_free_gserial;
+ }
+
+ ret = gnss_serial_register(gserial);
+ if (ret)
+ goto err_free_gserial;
+
+ return 0;
+
+err_free_gserial:
+ gnss_serial_free(gserial);
+
+ return ret;
+}
+
+static void ubx_remove(struct serdev_device *serdev)
+{
+ struct gnss_serial *gserial = serdev_device_get_drvdata(serdev);
+
+ gnss_serial_deregister(gserial);
+ gnss_serial_free(gserial);
+};
+
+#ifdef CONFIG_OF
+static const struct of_device_id ubx_of_match[] = {
+ { .compatible = "u-blox,neo-8" },
+ { .compatible = "u-blox,neo-m8" },
+ {},
+};
+MODULE_DEVICE_TABLE(of, ubx_of_match);
+#endif
+
+static struct serdev_device_driver ubx_driver = {
+ .driver = {
+ .name = "gnss-ubx",
+ .of_match_table = of_match_ptr(ubx_of_match),
+ .pm = &gnss_serial_pm_ops,
+ },
+ .probe = ubx_probe,
+ .remove = ubx_remove,
+};
+module_serdev_device_driver(ubx_driver);
+
+MODULE_AUTHOR("Johan Hovold <johan@kernel.org>");
+MODULE_DESCRIPTION("u-blox GNSS receiver driver");
+MODULE_LICENSE("GPL v2");
--
2.17.0
next prev parent reply other threads:[~2018-04-24 16:34 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 16:34 [PATCH 0/7] gnss: add new GNSS subsystem Johan Hovold
2018-04-24 16:34 ` [PATCH 1/7] gnss: add GNSS receiver subsystem Johan Hovold
2018-04-25 8:56 ` Greg Kroah-Hartman
2018-04-25 10:56 ` Johan Hovold
2018-04-25 12:23 ` Johan Hovold
2018-04-29 13:35 ` Greg Kroah-Hartman
2018-05-02 7:57 ` Johan Hovold
2018-04-24 16:34 ` [PATCH 2/7] dt-bindings: add generic gnss binding Johan Hovold
2018-04-25 18:26 ` Rob Herring
2018-04-24 16:34 ` [PATCH 3/7] gnss: add generic serial driver Johan Hovold
2018-04-25 8:57 ` Greg Kroah-Hartman
2018-04-25 10:58 ` Johan Hovold
2018-04-25 9:00 ` Greg Kroah-Hartman
2018-04-25 11:05 ` Johan Hovold
2018-04-24 16:34 ` [PATCH 4/7] dt-bindings: gnss: add u-blox binding Johan Hovold
2018-04-25 18:16 ` Rob Herring
2018-04-26 9:10 ` Johan Hovold
2018-05-01 14:05 ` Rob Herring
2018-05-02 8:16 ` Johan Hovold
2018-05-02 13:16 ` Rob Herring
2018-05-07 9:06 ` Johan Hovold
2018-05-03 9:35 ` H. Nikolaus Schaller
2018-05-03 18:50 ` Andreas Kemnade
2018-05-04 5:16 ` H. Nikolaus Schaller
2018-05-04 11:42 ` Sebastian Reichel
2018-05-04 12:04 ` H. Nikolaus Schaller
2018-05-04 13:37 ` Sebastian Reichel
2018-05-04 14:29 ` Tony Lindgren
2018-05-07 10:07 ` Johan Hovold
2018-05-07 10:01 ` Johan Hovold
2018-05-07 15:45 ` Tony Lindgren
2018-05-07 16:34 ` Johan Hovold
2018-05-07 17:50 ` Tony Lindgren
2018-05-08 6:58 ` Johan Hovold
2018-05-08 15:22 ` Tony Lindgren
2018-05-08 15:47 ` Tony Lindgren
2018-05-08 15:54 ` Tony Lindgren
2018-05-08 16:49 ` Tony Lindgren
2018-05-09 13:10 ` OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding)) Johan Hovold
2018-05-09 13:57 ` Tony Lindgren
2018-05-17 10:09 ` Johan Hovold
2018-05-17 17:10 ` Tony Lindgren
2018-05-21 13:48 ` Johan Hovold
2018-05-21 15:48 ` Tony Lindgren
2018-05-24 9:17 ` Johan Hovold
2018-05-24 13:32 ` Tony Lindgren
2018-05-25 14:02 ` Johan Hovold
2018-05-08 15:56 ` [PATCH 4/7] dt-bindings: gnss: add u-blox binding Sebastian Reichel
2018-05-09 9:18 ` Serdev runtime PM (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding) Johan Hovold
2018-05-09 9:49 ` Johan Hovold
2018-05-09 14:05 ` Tony Lindgren
2018-05-17 10:25 ` Johan Hovold
2018-05-07 9:47 ` [PATCH 4/7] dt-bindings: gnss: add u-blox binding Johan Hovold
2018-04-24 16:34 ` Johan Hovold [this message]
2018-04-24 16:34 ` [PATCH 6/7] dt-bindings: gnss: add sirfstar binding Johan Hovold
2018-04-25 18:25 ` Rob Herring
2018-04-26 9:12 ` Johan Hovold
2018-04-24 16:34 ` [PATCH 7/7] gnss: add driver for sirfstar-based receivers Johan Hovold
2018-04-24 17:40 ` [PATCH 0/7] gnss: add new GNSS subsystem H. Nikolaus Schaller
2018-04-24 17:50 ` Johan Hovold
2018-04-24 19:44 ` H. Nikolaus Schaller
2018-04-25 8:11 ` Johan Hovold
2018-04-26 10:10 ` H. Nikolaus Schaller
2018-04-26 18:21 ` Johan Hovold
2018-04-24 20:13 ` Pavel Machek
2018-04-24 20:59 ` Andreas Kemnade
2018-04-25 7:32 ` Johan Hovold
2018-04-25 6:49 ` Marcel Holtmann
2018-04-25 7:24 ` Johan Hovold
2018-04-24 20:38 ` Pavel Machek
2018-04-25 6:26 ` Pavel Machek
2018-04-25 6:51 ` Johan Hovold
2018-04-25 8:48 ` Greg Kroah-Hartman
2018-04-25 10:31 ` Johan Hovold
2018-05-04 13:27 ` Sebastian Reichel
2018-05-04 20:03 ` Pavel Machek
2018-05-05 17:28 ` Sebastian Reichel
2018-05-05 21:11 ` Pavel Machek
2018-05-06 6:47 ` Marcel Holtmann
2018-05-07 10:20 ` Johan Hovold
2018-05-07 19:06 ` Marcel Holtmann
2018-05-08 7:01 ` Johan Hovold
2018-05-08 7:49 ` Marcel Holtmann
2018-05-08 12:48 ` Johan Hovold
2018-05-08 20:03 ` Marcel Holtmann
2018-05-30 10:26 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424163458.11947-6-johan@kernel.org \
--to=johan@kernel.org \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).