From: Leon Romanovsky <leon@kernel.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Faisal Latif <faisal.latif@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/nes: fix nes_netdev_start_xmit()'s return type
Date: Tue, 24 Apr 2018 20:36:12 +0300 [thread overview]
Message-ID: <20180424173612.GI24820@mtr-leonro.local> (raw)
In-Reply-To: <20180424131545.2810-1-luc.vanoostenryck@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On Tue, Apr 24, 2018 at 03:15:45PM +0200, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> drivers/infiniband/hw/nes/nes_nic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ipoib_start_xmit() needs the same fix.
Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-24 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 13:15 [PATCH] IB/nes: fix nes_netdev_start_xmit()'s return type Luc Van Oostenryck
2018-04-24 17:36 ` Leon Romanovsky [this message]
2018-04-25 15:35 ` Leon Romanovsky
2018-04-27 18:08 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424173612.GI24820@mtr-leonro.local \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox