From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joey Pabalinas <joeypabalinas@gmail.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH v4 0/2] tty/nozomi: general module cleanup
Date: Wed, 25 Apr 2018 08:05:13 +0200 [thread overview]
Message-ID: <20180425060513.GA32729@kroah.com> (raw)
In-Reply-To: <cover.1524634929.git.joeypabalinas@gmail.com>
On Tue, Apr 24, 2018 at 07:48:02PM -1000, Joey Pabalinas wrote:
> The nozomi module has a few sections which could use a bit of cleanup;
> both style and clarity could be improved while maintaining equivalent
> semantics.
>
> Cleanup messy portions of the module code while preserving existing
> behavior by:
>
> - Replacing constructs like `len__ > TMP_BUF_MAX ? TMP_BUF_MAX : len__`
> with `min_t(u32, len__, TMP_BUF_MAX)` and function calls like
> snprintf(tbuf, ..., "%s", ...). with strscpy(tbuf, ..., ...).
> - Correct inconsistently indented lines and extraneous whitespace.
>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Jiri Slaby <jslaby@suse.cz>
>
> Joey Pabalinas (2):
> tty/nozomi: cleanup DUMP() macro
> tty/nozomi: fix inconsistent indentation
>
> drivers/tty/nozomi.c | 100 +++++++++++++++++++++----------------------
> 1 file changed, 50 insertions(+), 50 deletions(-)
What changed between versions of this series?
greg k-h
next prev parent reply other threads:[~2018-04-25 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 5:48 [PATCH v4 0/2] tty/nozomi: general module cleanup Joey Pabalinas
2018-04-25 5:48 ` [PATCH v4 1/2] tty/nozomi: cleanup DUMP() macro Joey Pabalinas
2018-04-25 5:48 ` [PATCH v4 2/2] tty/nozomi: fix inconsistent indentation Joey Pabalinas
2018-04-25 6:05 ` Greg Kroah-Hartman [this message]
2018-04-25 6:24 ` [PATCH v4 0/2] tty/nozomi: general module cleanup Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425060513.GA32729@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=joeypabalinas@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox