From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joey Pabalinas <joeypabalinas@gmail.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro
Date: Wed, 25 Apr 2018 08:09:31 +0200 [thread overview]
Message-ID: <20180425060931.GA595@kroah.com> (raw)
In-Reply-To: <20180425054530.gifahvwftdbjuo7x@gmail.com>
On Tue, Apr 24, 2018 at 07:45:30PM -1000, Joey Pabalinas wrote:
> On Wed, Apr 25, 2018 at 07:38:48AM +0200, Greg Kroah-Hartman wrote:
> > How are you sending these patches? How are you creating them? What is
> > taking part of the diffstat off and just leaving that line?
>
> Hm, my `git format-patch` alias included --shortstat for some odd reason,
> very sorry about that.
>
> Going to resend.
Ah, never seen that before. Just use the defaults and you should be
fine. Having the normal diffstat is good.
thanks,
greg k-h
next prev parent reply other threads:[~2018-04-25 6:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 22:39 [PATCH v3 0/2] tty/nozomi: general module cleanup Joey Pabalinas
2018-04-24 22:39 ` [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro Joey Pabalinas
2018-04-25 5:38 ` Greg Kroah-Hartman
2018-04-25 5:45 ` Joey Pabalinas
2018-04-25 6:09 ` Greg Kroah-Hartman [this message]
2018-04-25 6:34 ` Joey Pabalinas
2018-04-24 22:39 ` [PATCH v3 2/2] tty/nozomi: fix inconsistent indentation Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425060931.GA595@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=joeypabalinas@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox