From: Christoph Hellwig <hch@infradead.org>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] dma mapping fixes for 4.17-rc3
Date: Tue, 24 Apr 2018 23:59:30 -0700 [thread overview]
Message-ID: <20180425065930.GA16791@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1804242352290.51102@chino.kir.corp.google.com>
On Tue, Apr 24, 2018 at 11:54:26PM -0700, David Rientjes wrote:
> Shouldn't that test for dev->coherent_dma_mask < DMA_BIT_MASK(32) be more
> accurately <=?
No, it should really be <. The exactly 32-bit case is already covered
with GFP_DMA32. Eventualy it should be < 24-bit with a separate
GFP_DMA32 case for > 32-bit && < 64-bit. Takashi has been working on
that, but it is 4.18 material.
next prev parent reply other threads:[~2018-04-25 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 5:22 [GIT PULL] dma mapping fixes for 4.17-rc3 Christoph Hellwig
2018-04-25 6:54 ` David Rientjes
2018-04-25 6:59 ` Christoph Hellwig [this message]
2018-04-25 7:09 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425065930.GA16791@infradead.org \
--to=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox