public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: salyzyn@android.com, mingo@kernel.org, peterz@infradead.org,
	john.stultz@linaro.org, hpa@zytor.com, mtk.manpages@gmail.com,
	prarit@redhat.com, torvalds@linux-foundation.org,
	rostedt@goodmis.org, kevin@guarana.org,
	dmitry.torokhov@gmail.com, pmladek@suse.com, rjw@rjwysocki.net,
	linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com,
	tglx@linutronix.de, corbet@lwn.net
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/urgent] Revert: Unify CLOCK_MONOTONIC and CLOCK_BOOTTIME
Date: Thu, 26 Apr 2018 22:38:11 +0200	[thread overview]
Message-ID: <20180426203811.GA9975@amd> (raw)
In-Reply-To: <tip-757d5a9b3052a4eebd029f207f1e1df59bef7b7d@git.kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2011 bytes --]

On Wed 2018-04-25 06:45:50, tip-bot for Thomas Gleixner wrote:
> Commit-ID:  757d5a9b3052a4eebd029f207f1e1df59bef7b7d
> Gitweb:     https://git.kernel.org/tip/757d5a9b3052a4eebd029f207f1e1df59bef7b7d
> Author:     Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Wed, 25 Apr 2018 15:33:38 +0200
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 25 Apr 2018 15:35:08 +0200
> 
> Revert: Unify CLOCK_MONOTONIC and CLOCK_BOOTTIME
> 
> Revert commits
> 
> 92af4dcb4e1c ("tracing: Unify the "boot" and "mono" tracing clocks")
> 127bfa5f4342 ("hrtimer: Unify MONOTONIC and BOOTTIME clock behavior")
> 7250a4047aa6 ("posix-timers: Unify MONOTONIC and BOOTTIME clock behavior")
> d6c7270e913d ("timekeeping: Remove boot time specific code")
> f2d6fdbfd238 ("Input: Evdev - unify MONOTONIC and BOOTTIME clock behavior")
> d6ed449afdb3 ("timekeeping: Make the MONOTONIC clock behave like the BOOTTIME clock")
> 72199320d49d ("timekeeping: Add the new CLOCK_MONOTONIC_ACTIVE clock")
> 
> As stated in the pull request for the unification of CLOCK_MONOTONIC and
> CLOCK_BOOTTIME, it was clear that we might have to revert the change.
> 
> As reported by several folks systemd and other applications rely on the
> documented behaviour of CLOCK_MONOTONIC on Linux and break with the above
> changes. After resume daemons time out and other timeout related issues are
> observed.
> 
> It's sad, that these problems were neither catched in -next nor by those
> folks who expressed interest in this change.
> 
> Reported-by: Rafael J. Wysocki <rjw@rjwysocki.net>
> Reported-by: Genki Sky <sky@genki.is>,

Tested-by: Pavel Machek <pavel@ucw.cz>

Both screensaver problem and network problems are gone on X60 after I
applied the revert. (I did not do too many tests, but it was normally
too easy to reproduce.)

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply	other threads:[~2018-04-26 20:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-757d5a9b3052a4eebd029f207f1e1df59bef7b7d@git.kernel.org>
2018-04-25 17:31 ` [tip:timers/urgent] Revert: Unify CLOCK_MONOTONIC and CLOCK_BOOTTIME Linus Torvalds
2018-04-25 19:09   ` Thomas Gleixner
2018-04-25 19:41     ` Linus Torvalds
2018-04-25 20:19       ` Pavel Machek
2018-04-26  6:53         ` Rafael J. Wysocki
2018-04-26  7:19           ` Pavel Machek
2018-04-26  7:26             ` Rafael J. Wysocki
2018-04-25 20:57       ` Rafael J. Wysocki
2018-04-25 22:41         ` Steven Rostedt
2018-04-26  6:48           ` Rafael J. Wysocki
2018-04-25 21:28     ` Rafael J. Wysocki
2018-04-26  8:00       ` Rafael J. Wysocki
2018-04-26  8:53         ` Thomas Gleixner
2018-04-26 20:38 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426203811.GA9975@amd \
    --to=pavel@ucw.cz \
    --cc=corbet@lwn.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=kevin@guarana.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=prarit@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=salyzyn@android.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox