From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3556343-1524797313-2-16909101669627021609 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='US-ASCII' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1524797312; b=lfkfH4cxfZyGj476+re9boeJQoJdzXAQG9Ct83f1kqMVUda0aZ ZqHOumUsNcrOnpRNKT0gX1BKg4jj27SpMZJjNSBGHDPeS/2WqiaX6qwyiw/gCOwI FttSoOic5Yt2MRVVlx6VmAmqW+Pw8YW6jFKmzWNpA9IsmQEYYLR4sg0nkdymt3h3 IRWYkN35NCEADAB3qk6zf6OZqNmAHGuinnZ6B6RW2tKojstvh+1DnYIhyucSE/Df b1jyLS/yUCLqlC6LQ0vsfr4K1+54ySy8pl6s/ADVGGjcrOE4vbNE1ze45Jv52O0I DK0iPVcc1Fx/nhESz1R8g4BBTlvBMFcOF0Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding:sender:list-id; s=fm2; t=1524797312; bh=HCvjC1kBVBf4hwV5oODbi5CFfZIylrKWxIdlcm7O2dw=; b=XBwwpvf5p0E8 OX3+R46OQu/mX6tIcR8Ld+VCVnOaNF68T+P8r2I42PMdOnUwYgbFlcPD5rMb1ROp asf+b9N971Gnk97Jh4JkYzg+jbj3iQb/2Jko8wNGERBksdFudc2uDgP+xVUu5kKi aocW0wuy7sXy8bDVSz6Fz9yZ+PEVxGtllohIMeqSjjvltlFMyP4MAC+a6WLje21S RliYEmxlz0pNinj7sDx6osQ+0FPG5wCNP7iM8ulAXczuLMB9EB8lZgXn6AdR42No QXsZx3bxo5HzlSrZDyF/tGRqlJpFRW8jEaaSdpgW9vyz39Qcsm2BpQd78AbMFntT 1Y6h7na+fQ== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=goodmis.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=goodmis.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=goodmis.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=goodmis.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfAh32gM7BePP9bZszH0Cxb+Ld1SLoIvW/2dxs5eTAw7LQ00n+zMXsvZdIMBz/gS9Vtc6STvEx7nd8jwrbRdJP8ssSwhIRD8KxhpjCoJtGsETo9nr3HHn nCFtUrVQhvuDq0qJ7pKuMkPIdq6QnKxHjE9Bzl/UwRpLlafw0OFfU2NV8onWLwYhhBB9QzXXj3V6IoBhIITf+bdvj1/GJNQ69p2EpP8tp93Zp6WZ+GQrmFKE X-CM-Analysis: v=2.3 cv=E8HjW5Vl c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=kj9zAlcOel0A:10 a=Kd1tUaAdevIA:10 a=VwQbUJbxAAAA:8 a=meVymXHHAAAA:8 a=YN6vI2Lh6dk2EElT4j4A:9 a=SVCumtVKCdp6hC9d:21 a=1YyH5Fv4akvSS-Hw:21 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=2JgSa4NbpEOStq-L5dxp:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757046AbeD0Cs3 (ORCPT ); Thu, 26 Apr 2018 22:48:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:39464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbeD0Cs2 (ORCPT ); Thu, 26 Apr 2018 22:48:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15A0A2184F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 26 Apr 2018 22:48:24 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S . Miller" , Jon Medhurst , Will Deacon , Arnd Bergmann , David Howells , Heiko Carstens , "Tobin C . Harding" , Linus Torvalds , Thomas Richter , akpm@linux-foundation.org, acme@kernel.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, stable@vger.kernel.org Subject: Re: [PATCH -tip v2 4/7] kprobes: Replace %p with other pointer types Message-ID: <20180426224824.3492232e@vmware.local.home> In-Reply-To: <20180427113951.8e3192af570c0bae925b2a71@kernel.org> References: <152473007907.8819.10449983839199591406.stgit@devbox> <152473020349.8819.11597612324633031612.stgit@devbox> <20180426211351.419d3502@vmware.local.home> <20180427113951.8e3192af570c0bae925b2a71@kernel.org> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, 27 Apr 2018 11:39:51 +0900 Masami Hiramatsu wrote: > On Thu, 26 Apr 2018 21:13:51 -0400 > Steven Rostedt wrote: > > > On Thu, 26 Apr 2018 17:10:03 +0900 > > Masami Hiramatsu wrote: > > > > > Replace %p with appropriate pointer types (or just remove it) > > > - Use %pS if possible > > > - Use %px only for the function right before BUG(). > > > - Remove unneeded error message. > > > > I'm not sure "right before BUG()" is legitimate for using %px. Why not > > still use %pS? > > Since BUG() will dump all registers and stacks which includes > raw address information and reboot the system (means reset the > kaslr base offset), I thought it may not add additional damage. BUG() has been changed to print out %pS and not the address while doing the stack dump. It only prints the address if it doesn't find a function name. For example: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.11.0-rc3-test+ #48 Hardware name: MSI MS-7823/CSM-H87M-G43 (MS-7823), BIOS V1.6 02/22/2014 Call Trace: dump_stack+0x68/0x92 lockdep_rcu_suspicious+0xf7/0x100 rcu_read_lock+0x5f/0x61 __is_insn_slot_addr+0x23/0x5c __kernel_text_address+0x4a/0x80 show_trace_log_lvl+0x157/0x296 ? module_assert_mutex_or_preempt+0x4f/0x51 show_stack+0x3d/0x3f dump_stack+0x68/0x92 __warn+0xc2/0xdd ? 0xffffffffa0026077 warn_slowpath_null+0x1d/0x1f module_assert_mutex_or_preempt+0x4f/0x51 __module_address+0x2a/0xac ? 0xffffffffa0026077 __module_text_address+0x12/0x59 ? 0xffffffffa0026077 is_module_text_address+0xe/0x16 __kernel_text_address+0x2b/0x80 ? 0xffffffffa0026077 unwind_get_return_address+0x50/0x5c > > Anyway, for this patch we can use %pS. For the next [5/7] patch, > I'm not sure %pS is good for dumping a stack address... Although it now is. -- Steve