Re: [PATCH RFC] tracepoint: Introduce tracepoint callbacks executing with preempt on

Paul E. McKenney
2018-04-27T16:44:51Z

On Fri, Apr 27, 2018 at 12:22:01PM -0400, Steven Rostedt wrote:
> On Fri, 27 Apr 2018 09:14:30 -0700
> Joel Fernandes <joelaf@google.com> wrote:
>
> > > Hmmm... Do I need to create a _notrace variant of srcu_read_lock()
> > > and srcu_read_unlock()?
> >
> > That shouldn't be needed. For the rcu_read_lock_sched case, there is a
> > preempt_disable which needs to be a notrace, but for the srcu one,
> > since we don't do that, I think it should be fine.
>
> Actually, I think I may agree here too. Because the _notrace is for
> function tracing, and it shouldn't affect it. If people don't want it
> traced, they could add those functions to the list in the notrace file.

OK, feel free to ignore my notrace srcu_read_lock() patch, then. ;-)

Thanx, Paul