From: Jason Gunthorpe <jgg@ziepe.ca>
To: Greg Thelen <gthelen@google.com>
Cc: Doug Ledford <dledford@redhat.com>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
Christoph Hellwig <hch@lst.de>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Tarick Bedeir <tarick@google.com>
Subject: Re: [PATCH 3/5] ib_srpt: depend on INFINIBAND_ADDR_TRANS
Date: Mon, 30 Apr 2018 17:35:00 -0600 [thread overview]
Message-ID: <20180430233500.GI26909@ziepe.ca> (raw)
In-Reply-To: <20180425223340.206907-1-gthelen@google.com>
On Wed, Apr 25, 2018 at 03:33:39PM -0700, Greg Thelen wrote:
> INFINIBAND_SRPT code depends on INFINIBAND_ADDR_TRANS provided symbols.
> So declare the kconfig dependency. This is necessary to allow for
> enabling INFINIBAND without INFINIBAND_ADDR_TRANS.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
> Cc: Tarick Bedeir <tarick@google.com>
> drivers/infiniband/ulp/srpt/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/Kconfig b/drivers/infiniband/ulp/srpt/Kconfig
> index 31ee83d528d9..fb8b7182f05e 100644
> +++ b/drivers/infiniband/ulp/srpt/Kconfig
> @@ -1,6 +1,6 @@
> config INFINIBAND_SRPT
> tristate "InfiniBand SCSI RDMA Protocol target support"
> - depends on INFINIBAND && TARGET_CORE
> + depends on INFINIBAND && INFINIBAND_ADDR_TRANS && TARGET_CORE
Isn't INFINIBAND && INFINIBAND_ADDR_TRANS a bit redundant? Can't have
INFINIBAND_ADDR_TRANS without INFINIBAND.
Jason
next prev parent reply other threads:[~2018-04-30 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 22:33 [PATCH 3/5] ib_srpt: depend on INFINIBAND_ADDR_TRANS Greg Thelen
2018-04-30 23:35 ` Jason Gunthorpe [this message]
2018-05-01 3:08 ` Greg Thelen
2018-05-01 17:08 ` Doug Ledford
2018-05-01 20:48 ` Jason Gunthorpe
2018-05-04 3:30 ` Greg Thelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430233500.GI26909@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Bart.VanAssche@wdc.com \
--cc=dledford@redhat.com \
--cc=gthelen@google.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tarick@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox