Re: [PATCH] sched/fair: make CFS bandwidth slice per cpu group

kbuild test robot
2018-05-01T00:30:19Z

Hi Cong,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on v4.17-rc3 next-20180430]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Cong-Wang/sched-fair-make-CFS-bandwidth-slice-per-cpu-group/20180501-064013
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__

sparse warnings: (new ones prefixed by >>)

kernel/sched/core.c:509:9: sparse: incompatible types in comparison expression (different address spaces)
kernel/sched/core.c:1614:17: sparse: incompatible types in comparison expression (different address spaces)
kernel/sched/core.c:1802:27: sparse: incompatible types in comparison expression (different address spaces)
kernel/sched/core.c:6541:11: sparse: symbol 'max_cfs_quota_period' was not declared. Should it be static?
kernel/sched/core.c:6542:11: sparse: symbol 'min_cfs_quota_period' was not declared. Should it be static?
kernel/sched/core.c:6622:5: sparse: symbol 'tg_set_cfs_quota' was not declared. Should it be static?
kernel/sched/core.c:6635:6: sparse: symbol 'tg_get_cfs_quota' was not declared. Should it be static?
kernel/sched/core.c:6648:5: sparse: symbol 'tg_set_cfs_period' was not declared. Should it be static?
kernel/sched/core.c:6658:6: sparse: symbol 'tg_get_cfs_period' was not declared. Should it be static?
>> kernel/sched/core.c:6668:5: sparse: symbol 'tg_set_cfs_slice' was not declared. Should it be static?
>> kernel/sched/core.c:6686:6: sparse: symbol 'tg_get_cfs_slice' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation