From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753789AbeEAI3N (ORCPT ); Tue, 1 May 2018 04:29:13 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:37808 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbeEAI3K (ORCPT ); Tue, 1 May 2018 04:29:10 -0400 X-Google-Smtp-Source: AB8JxZoV8AH2P/fwUA0kqLVEgVkWBELwmvjrMpsZg2hVfoTJFS2JwxxW4JXILtuhKy4GgXb1S1jQDA== Date: Tue, 1 May 2018 09:29:05 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Sebastian Reichel , Gwendal Grignou , Sameer Nanda , linux-pm@vger.kernel.org, Guenter Roeck , linux-kernel@vger.kernel.org, Benson Leung , miguel.ojeda.sandonis@gmail.com Subject: Re: [PATCH v2 1/3] mfd: cros_ec: Add USBPD charger commands and struct definitions. Message-ID: <20180501082905.GJ5147@dell> References: <20180430131403.14296-1-enric.balletbo@collabora.com> <20180430131403.14296-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180430131403.14296-2-enric.balletbo@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Apr 2018, Enric Balletbo i Serra wrote: > From: Sameer Nanda > > The USBPD charger driver gets information from the ChromeOS EC, this > patch adds the USBPD charger definitions needed by this driver. > > Signed-off-by: Sameer Nanda > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v2: None > > include/linux/mfd/cros_ec_commands.h | 132 ++++++++++++++++++++++++++- > 1 file changed, 128 insertions(+), 4 deletions(-) > > diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h > index f2edd9969b40..94dcf331796c 100644 > --- a/include/linux/mfd/cros_ec_commands.h > +++ b/include/linux/mfd/cros_ec_commands.h [...] > +struct ec_response_pd_log { > + uint32_t timestamp; /* relative timestamp in milliseconds */ > + uint8_t type; /* event type : see PD_EVENT_xx below */ > + uint8_t size_port; /* [7:5] port number [4:0] payload size in bytes */ > + uint16_t data; /* type-defined data payload */ > + uint8_t payload[0]; /* optional additional data payload: 0..16 bytes */ > +} __packed; I think this whole file should be converted to Kerneldoc format. [...] > +/* > + * PD_EVENT_MCU_CHARGE event definition : > + * the payload is "struct usb_chg_measures" > + * the data field contains the port state flags as defined below : > + */ > +/* Port partner is a dual role device */ > +#define CHARGE_FLAGS_DUAL_ROLE (1 << 15) BIT()? > +/* Port is the pending override port */ > +#define CHARGE_FLAGS_DELAYED_OVERRIDE (1 << 14) > +/* Port is the override port */ > +#define CHARGE_FLAGS_OVERRIDE (1 << 13) [...] -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog