From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755117AbeEAN1I (ORCPT ); Tue, 1 May 2018 09:27:08 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:52380 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbeEAN1G (ORCPT ); Tue, 1 May 2018 09:27:06 -0400 X-Google-Smtp-Source: AB8JxZpx+KyOqcjayOblZtunWNSj/qOEyIhTE1jYkvN6CjMC8uwqgoVJbnIZUpk+kAuhCCqJ+JAhCQ== Date: Tue, 1 May 2018 14:27:02 +0100 From: Lee Jones To: Sebastian Reichel Cc: Enric Balletbo i Serra , Gwendal Grignou , Sameer Nanda , linux-pm@vger.kernel.org, Guenter Roeck , linux-kernel@vger.kernel.org, Benson Leung , miguel.ojeda.sandonis@gmail.com Subject: Re: [PATCH v2 2/3] power: supply: add cros-ec USBPD charger driver. Message-ID: <20180501132702.GP5147@dell> References: <20180430131403.14296-1-enric.balletbo@collabora.com> <20180430131403.14296-3-enric.balletbo@collabora.com> <20180501121728.65bow5vzpzfeq4en@earth.universe> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180501121728.65bow5vzpzfeq4en@earth.universe> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 01 May 2018, Sebastian Reichel wrote: > Hi Enric, > > On Mon, Apr 30, 2018 at 03:14:02PM +0200, Enric Balletbo i Serra wrote: > > From: Sameer Nanda > > > > This driver gets various bits of information about what is connected to > > USB PD ports from the EC and converts that into power_supply properties. > > > > Signed-off-by: Sameer Nanda > > Signed-off-by: Enric Balletbo i Serra > > --- > > > > Changes in v2: > > - [2/3] Add SPDX header, use devm_ variant and drop .owner > > - [2/3] Removed the PD log functionality (will be send on a follow up patch) > > - [2/3] Removed the extra custom sysfs attributes (will be send on a follow up patch) > > Thanks, it makes reviewing the patchset easier. > > > drivers/power/supply/Kconfig | 10 + > > drivers/power/supply/Makefile | 1 + > > drivers/power/supply/cros_usbpd-charger.c | 511 ++++++++++++++++++++++ > > include/linux/mfd/cros_ec.h | 2 + > > 4 files changed, 524 insertions(+) > > create mode 100644 drivers/power/supply/cros_usbpd-charger.c [...] Sebastian, When you review a patch, would you mind chopping/snipping unnecessary text please? The chunks in-between the ones you reply to. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog