From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/3] random: Return nbytes filled from hw RNG
Date: Tue, 1 May 2018 20:19:21 -0400 [thread overview]
Message-ID: <20180502001921.GB24100@thunk.org> (raw)
In-Reply-To: <1525217620-4107-3-git-send-email-me@tobin.cc>
On Wed, May 02, 2018 at 09:33:39AM +1000, Tobin C. Harding wrote:
> Currently the function get_random_bytes_arch() has return value 'void'.
> If the hw RNG fails we currently fall back to using get_random_bytes().
> This defeats the purpose of requesting random material from the hw RNG
> in the first place.
>
> There are currently no intree users of get_random_bytes_arch().
>
> Only get random bytes from the hw RNG, make function return the number
> of bytes retrieved from the hw RNG.
>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
Acked-by: Theodore Ts'o <tytso@mit.edu>
next prev parent reply other threads:[~2018-05-02 0:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 23:33 [PATCH 0/3] enable early printing of hashed pointers Tobin C. Harding
2018-05-01 23:33 ` [PATCH 1/3] random: Fix whitespace pre random-bytes work Tobin C. Harding
2018-05-02 0:18 ` Theodore Y. Ts'o
2018-05-01 23:33 ` [PATCH 2/3] random: Return nbytes filled from hw RNG Tobin C. Harding
2018-05-01 23:44 ` Tobin C. Harding
2018-05-02 0:19 ` Theodore Y. Ts'o [this message]
2018-05-02 1:39 ` Steven Rostedt
2018-05-02 2:07 ` Tobin C. Harding
2018-05-01 23:33 ` [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option Tobin C. Harding
2018-05-02 1:02 ` Linus Torvalds
2018-05-02 1:27 ` tcharding
2018-05-02 1:45 ` Steven Rostedt
2018-05-02 2:05 ` tcharding
2018-05-02 2:51 ` Linus Torvalds
2018-05-02 21:56 ` Andrew Morton
2018-05-03 2:56 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502001921.GB24100@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox