From: "Tobin C. Harding" <me@tobin.cc>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Kees Cook <keescook@chromium.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Theodore Ts'o <tytso@mit.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/3] random: Return nbytes filled from hw RNG
Date: Wed, 2 May 2018 12:07:22 +1000 [thread overview]
Message-ID: <20180502020722.GF3791@eros> (raw)
In-Reply-To: <20180501213902.4ea6bbf9@vmware.local.home>
On Tue, May 01, 2018 at 09:39:02PM -0400, Steven Rostedt wrote:
> On Wed, 2 May 2018 09:33:39 +1000
> "Tobin C. Harding" <me@tobin.cc> wrote:
>
> > diff --git a/drivers/char/random.c b/drivers/char/random.c
> > index 031d18b31e0f..3a66507ea60b 100644
> > --- a/drivers/char/random.c
> > +++ b/drivers/char/random.c
> > @@ -1725,26 +1725,28 @@ EXPORT_SYMBOL(del_random_ready_callback);
> > * key known by the NSA). So it's useful if we need the speed, but
> > * only if we're willing to trust the hardware manufacturer not to
> > * have put in a back door.
> > + *
> > + * Return number of bytes filled in.
> > */
> > -void get_random_bytes_arch(void *buf, int nbytes)
> > +int __must_check get_random_bytes_arch(void *buf, int nbytes)
>
> The "__must_check" makes no sense in the C file. It belongs in the
> header file. There wont be any complaint about it here.
Oh thanks.
/steve schooling noobs all day long
next prev parent reply other threads:[~2018-05-02 2:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 23:33 [PATCH 0/3] enable early printing of hashed pointers Tobin C. Harding
2018-05-01 23:33 ` [PATCH 1/3] random: Fix whitespace pre random-bytes work Tobin C. Harding
2018-05-02 0:18 ` Theodore Y. Ts'o
2018-05-01 23:33 ` [PATCH 2/3] random: Return nbytes filled from hw RNG Tobin C. Harding
2018-05-01 23:44 ` Tobin C. Harding
2018-05-02 0:19 ` Theodore Y. Ts'o
2018-05-02 1:39 ` Steven Rostedt
2018-05-02 2:07 ` Tobin C. Harding [this message]
2018-05-01 23:33 ` [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option Tobin C. Harding
2018-05-02 1:02 ` Linus Torvalds
2018-05-02 1:27 ` tcharding
2018-05-02 1:45 ` Steven Rostedt
2018-05-02 2:05 ` tcharding
2018-05-02 2:51 ` Linus Torvalds
2018-05-02 21:56 ` Andrew Morton
2018-05-03 2:56 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502020722.GF3791@eros \
--to=me@tobin.cc \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox