From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532AbeEBJ5R (ORCPT ); Wed, 2 May 2018 05:57:17 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36082 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbeEBJ5N (ORCPT ); Wed, 2 May 2018 05:57:13 -0400 X-Google-Smtp-Source: AB8JxZp7l3fOUHN9KtaTfYMY7Wb0IxWlcLHK/+HkfY6h81TlTrLYVOpQAGfH6e+igP/fY0fBzgfKlA== From: Bartosz Golaszewski To: Ohad Ben-Cohen , Bjorn Andersson , Sekhar Nori , David Lechner , Suman Anna , Aparna Balasubramanian , Kevin Hilman Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 3/3] remoteproc/davinci: use octal permissions for module_param() Date: Wed, 2 May 2018 11:56:59 +0200 Message-Id: <20180502095659.3626-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180502095659.3626-1-brgl@bgdev.pl> References: <20180502095659.3626-1-brgl@bgdev.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Checkpatch recommends to use octal perms instead of S_IRUGO. Signed-off-by: Bartosz Golaszewski Reviewed-by: Sekhar Nori Acked-by: Suman Anna --- drivers/remoteproc/da8xx_remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c index f134192922e0..b668e32996e2 100644 --- a/drivers/remoteproc/da8xx_remoteproc.c +++ b/drivers/remoteproc/da8xx_remoteproc.c @@ -25,7 +25,7 @@ #include "remoteproc_internal.h" static char *da8xx_fw_name; -module_param(da8xx_fw_name, charp, S_IRUGO); +module_param(da8xx_fw_name, charp, 0444); MODULE_PARM_DESC(da8xx_fw_name, "Name of DSP firmware file in /lib/firmware (if not specified defaults to 'rproc-dsp-fw')"); -- 2.17.0