From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbeECDEy (ORCPT ); Wed, 2 May 2018 23:04:54 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:45914 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbeECDEu (ORCPT ); Wed, 2 May 2018 23:04:50 -0400 X-Google-Smtp-Source: AB8JxZrfFmdtxltNLrPlfapLN3ZZvG7B8h6beXYwigeNH4J5axwjPmKOxDJtxRZYScHpjBWUinUaWg== From: Chris Chiu To: corentin.chary@gmail.com, dvhart@infradead.org, andy@infradead.org Cc: acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux@endlessm.com, Chris Chiu , Jian-Hong Pan Subject: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support Date: Thu, 3 May 2018 11:04:38 +0800 Message-Id: <20180503030438.51150-1-chiu@endlessm.com> X-Mailer: git-send-email 2.15.1 (Apple Git-101) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard backlight toggle. In this UX550GE, the hotkey incremet the level of brightness for each keypress from 1 to 3, and then switch it off when the brightness has been the max. This commit interprets the code 0xc7 generated from hotkey to KEY_KBDILLUMUP to increment the brightness, then pass KEY_KBDILLUMTOGGLE to user space after the brightness max been reached for switching the led off. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan Tested-by: Jian-Hong Pan --- Notes: v2: - Remove redundant 'else' branch logic drivers/platform/x86/asus-nb-wmi.c | 1 + drivers/platform/x86/asus-wmi.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 136ff2b4cce5..14c502e18579 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform/x86/asus-nb-wmi.c @@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = { { KE_KEY, 0xC4, { KEY_KBDILLUMUP } }, { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } }, { KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */ + { KE_KEY, 0xC7, { KEY_KBDILLUMTOGGLE } }, { KE_END, 0}, }; diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 1f6e68f0b646..4a3ba575c9ce 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -67,6 +67,7 @@ MODULE_LICENSE("GPL"); #define NOTIFY_BRNDOWN_MAX 0x2e #define NOTIFY_KBD_BRTUP 0xc4 #define NOTIFY_KBD_BRTDWN 0xc5 +#define NOTIFY_KBD_BRTTOGGLE 0xc7 /* WMI Methods */ #define ASUS_WMI_METHODID_SPEC 0x43455053 /* BIOS SPECification */ @@ -1745,6 +1746,10 @@ static void asus_wmi_notify(u32 value, void *context) } } + if (code == NOTIFY_KBD_BRTTOGGLE) + if (asus->kbd_led_wk < asus->kbd_led.max_brightness) + code = NOTIFY_KBD_BRTUP; + if (is_display_toggle(code) && asus->driver->quirks->no_display_toggle) goto exit; -- 2.14.1