From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Schmaus <flo@geekplace.eu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] driver-core: Return EBUSY error instead of BUG_ON()
Date: Fri, 4 May 2018 10:37:09 -0700 [thread overview]
Message-ID: <20180504173709.GC4649@kroah.com> (raw)
In-Reply-To: <20180504132357.31771-1-flo@geekplace.eu>
On Fri, May 04, 2018 at 03:23:57PM +0200, Florian Schmaus wrote:
> I triggerd the BUG_ON() in driver_register(), which was added in
> f48f3febb2cbfd0f2ecee7690835ba745c1034a4, when booting a domU Xen
> domain. Since there was no contextual information logged, I needed to
> attach kgdb to determine the culprit (the wmi-bmof driver in my case).
>
> Instead of running into a BUG_ON() we print an error message
> identifying the driver but continue booting.
>
> Signed-off-by: Florian Schmaus <flo@geekplace.eu>
> ---
> drivers/base/driver.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
What changed from v1? Always put that below the --- line.
Also, it's best to quote commits with the following format:
f48f3febb2cb ("driver-core: do not register a driver with bus_type not registered")
v3?
thanks,
greg k-h
next prev parent reply other threads:[~2018-05-04 17:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 9:49 [PATCH] driver-core: Log the BUG() causing driver Florian Schmaus
2018-03-07 15:13 ` Greg Kroah-Hartman
2018-03-07 15:36 ` Florian Schmaus
2018-05-04 13:23 ` [PATCH v2] driver-core: Return EBUSY error instead of BUG_ON() Florian Schmaus
2018-05-04 17:37 ` Greg Kroah-Hartman [this message]
2018-05-04 17:38 ` Greg Kroah-Hartman
2018-05-15 13:51 ` [PATCH v3 0/3] return EINVAL " Florian Schmaus
2018-05-16 12:05 ` [PATCH v4 " Florian Schmaus
2018-05-16 16:08 ` [PATCH v5 " Florian Schmaus
2018-05-23 15:59 ` [PATCH v6 0/3] driver-core: " Florian Schmaus
2018-05-25 16:21 ` Greg Kroah-Hartman
2018-05-23 15:59 ` [PATCH v6 1/3] " Florian Schmaus
2018-05-23 15:59 ` [PATCH v6 2/3] driver-core: record error on bus registration Florian Schmaus
2018-05-23 15:59 ` [PATCH v6 3/3] driver-core: print bus registration error value Florian Schmaus
2018-05-16 16:08 ` [PATCH v5 1/3] driver-core: return EINVAL error instead of BUG_ON() Florian Schmaus
2018-05-16 16:35 ` Greg Kroah-Hartman
2018-05-16 16:08 ` [PATCH v5 2/3] driver-core: record error on bus registration Florian Schmaus
2018-05-16 16:35 ` Greg Kroah-Hartman
2018-05-16 16:08 ` [PATCH v5 3/3] driver-core: print bus registration error value Florian Schmaus
2018-05-16 16:37 ` Greg Kroah-Hartman
2018-05-16 12:05 ` [PATCH v4 1/3] driver-core: return EINVAL error instead of BUG_ON() Florian Schmaus
2018-05-16 15:39 ` Greg Kroah-Hartman
2018-05-16 16:07 ` Florian Schmaus
2018-05-16 12:05 ` [PATCH v4 2/3] driver-core: record error on bus registration Florian Schmaus
2018-05-17 13:08 ` kbuild test robot
2018-05-16 12:05 ` [PATCH v4 3/3] driver-core: print bus registration error value Florian Schmaus
2018-05-16 12:09 ` Florian Schmaus
2018-05-16 15:38 ` Greg Kroah-Hartman
2018-05-16 15:37 ` Greg Kroah-Hartman
2018-05-17 8:10 ` kbuild test robot
2018-05-15 13:51 ` [PATCH v3 1/3] driver-core: return EINVAL error instead of BUG_ON() Florian Schmaus
2018-05-15 15:10 ` Greg Kroah-Hartman
2018-05-15 15:13 ` Greg Kroah-Hartman
2018-05-15 13:51 ` [PATCH v3 2/3] driver-core: record error on bus registration Florian Schmaus
2018-05-16 8:50 ` kbuild test robot
2018-05-15 13:51 ` [PATCH v3 3/3] driver-core: print bus registration error value Florian Schmaus
2018-05-15 15:12 ` Greg Kroah-Hartman
2018-05-16 8:24 ` kbuild test robot
2018-05-16 8:35 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504173709.GC4649@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=flo@geekplace.eu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox