Re: [PATCH v9 08/15] cobalt: set queue as unordered

Hans Verkuil
2018-05-07T11:04:46Z

On 04/05/18 22:06, Ezequiel Garcia wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.com>
>
> The cobalt driver may reorder the capture buffers so we need to report
> it as such.
>
> v3: set unordered as a property
> v2: use vb2_ops_set_unordered() helper
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> drivers/media/pci/cobalt/cobalt-v4l2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/pci/cobalt/cobalt-v4l2.c b/drivers/media/pci/cobalt/cobalt-v4l2.c
> index e2a4c705d353..8f06cc7f1c81 100644
> --- a/drivers/media/pci/cobalt/cobalt-v4l2.c
> +++ b/drivers/media/pci/cobalt/cobalt-v4l2.c
> @@ -1236,6 +1236,7 @@ static int cobalt_node_register(struct cobalt *cobalt, int node)
> q->min_buffers_needed = 2;
> q->lock = &s->lock;
> q->dev = &cobalt->pci_dev->dev;
> + q->unordered = 1;
> vdev->queue = q;
>
> video_set_drvdata(vdev, s);
>

As mentioned in my review of v8 of this patch, you also need to mark all formats
in this driver as unordered.

Regards,

Hans