From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Chunyan Zhang <chunyan.zhang@spreadtrum.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Baolin Wang <baolin.wang@spreadtrum.com>,
Orson Zhai <orson.zhai@spreadtrum.com>
Subject: Re: [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency
Date: Mon, 7 May 2018 09:49:43 +0200 [thread overview]
Message-ID: <20180507074943.GB19313@mai> (raw)
In-Reply-To: <CAAfSe-uBy00gR+Upcc1aO0LWwLMGT-WrCmt4oo_SiEXUcW+PuA@mail.gmail.com>
On Mon, May 07, 2018 at 02:04:38PM +0800, Chunyan Zhang wrote:
> Hi Daniel,
>
> On 7 May 2018 at 13:51, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> > On Thu, May 03, 2018 at 08:27:32PM +0800, Chunyan Zhang wrote:
> >> SPRD arch doesn't select SPRD_TIMER, so this config would not
> >> appear even if ARCH_SPRD is set and COMPILE_TEST is not.
> >>
> >> Fix the Kconfig selection rule by letting the SPRD arch to select.
> >
> > Instead of changing this Kconfig, please fix the arch's Kconfig by selecting
> > SPRD_TIMER.
>
> Oh, that's not my expectation, I hope we can give users permission of
> not selecting SPRD TIMER driver even if SPRD arch is selected. (I can
> confirm that all Spreadtrum's platforms in mainline can work without
> this driver. An enough minimum workable system doesn't need this
> driver indeed.)
Ok, can you add the EXPERT option in addition to the bool like:
https://lkml.org/lkml/2018/4/3/897
Thanks.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-05-07 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 12:27 [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency Chunyan Zhang
2018-05-07 5:51 ` Daniel Lezcano
2018-05-07 6:04 ` Chunyan Zhang
2018-05-07 7:49 ` Daniel Lezcano [this message]
2018-05-07 8:06 ` Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507074943.GB19313@mai \
--to=daniel.lezcano@linaro.org \
--cc=baolin.wang@spreadtrum.com \
--cc=chunyan.zhang@spreadtrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orson.zhai@spreadtrum.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox