From: "Michael Büsch" <m@bues.ch>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
"Matt Redfearn" <matt.redfearn@mips.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression caused by commit 882164a4a928
Date: Mon, 7 May 2018 20:43:17 +0200 [thread overview]
Message-ID: <20180507204317.52992b6c@wiggum> (raw)
In-Reply-To: <7bbc067a-c412-3d2e-174a-abc31b46e246@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]
On Mon, 7 May 2018 10:44:34 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Although commit 882164a4a928 ("ssb: Prevent build of PCI host features in
> module") appeared to be harmless, it leads to complete failure of drivers b43.
> config SSB_DRIVER_PCICORE_POSSIBLE
> bool
> - depends on SSB_PCIHOST && SSB = y
> + depends on SSB_PCIHOST && (SSB = y || !MIPS)
> default y
>
> config SSB_DRIVER_PCICORE
https://patchwork.kernel.org/patch/10161131/
Could we _please_ switch to not applying patches to ssb or b43, if
nobody acked (or better reviewed) a patch?
We had multiple changes to ssb and b43 in the recent past that did not
have a review at all and broke something. I don't think such software
quality is acceptable at all.
So please revert 882164a4a928.
I'm sorry that this patch slipped through the cracks of my inbox.
But the reaction to that shall not be to just apply the patch. It
shall be to resubmit it for review.
But back to the technical topic.
I don't remember why SSB_DRIVER_PCICORE_POSSIBLE depends on SSB_PCIHOST.
But that looks and feels wrong.
I would say it should rather look like
config SSB_DRIVER_PCICORE_POSSIBLE
depends on SSB && (PCI = y || PCI = SSB)
completely untested, though.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-07 18:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 15:44 Regression caused by commit 882164a4a928 Larry Finger
2018-05-07 18:43 ` Michael Büsch [this message]
2018-05-07 19:03 ` Kalle Valo
2018-05-07 19:30 ` Michael Büsch
2018-05-09 10:03 ` Kalle Valo
2018-05-09 12:55 ` Matt Redfearn
2018-05-09 16:27 ` Michael Büsch
2018-05-10 10:24 ` Matt Redfearn
2018-05-10 11:09 ` Michael Büsch
2018-05-10 10:41 ` Rafał Miłecki
2018-05-10 10:48 ` Rafał Miłecki
2018-05-10 10:49 ` Matt Redfearn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507204317.52992b6c@wiggum \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matt.redfearn@mips.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox