Re: [PATCH v6 12/13] Documentation: remove stale firmware API reference

Luis R. Rodriguez
2018-05-09T19:43:23Z

On Wed, May 09, 2018 at 12:12:09PM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 8 May 2018 11:12:46 -0700
> "Luis R. Rodriguez" <mcgrof@kernel.org> escreveu:
>
> > It refers to a pending patch, but this was merged eons ago.
>
> Didn't know that such patch was already merged. Great!
>
> Regards,
> Mauro
>
> >
> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > ---
> > Documentation/dell_rbu.txt | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/Documentation/dell_rbu.txt b/Documentation/dell_rbu.txt
> > index 0fdb6aa2704c..077fdc29a0d0 100644
> > --- a/Documentation/dell_rbu.txt
> > +++ b/Documentation/dell_rbu.txt
> > @@ -121,9 +121,6 @@ read back the image downloaded.
> >
> > .. note::
> >
> > - This driver requires a patch for firmware_class.c which has the modified
> > - request_firmware_nowait function.
> > -
>
> > Also after updating the BIOS image a user mode application needs to execute
> > code which sends the BIOS update request to the BIOS. So on the next reboot
> > the BIOS knows about the new image downloaded and it updates itself.
>
> You should likely remove the "Also" here.

Good catch. Will adjust.

>
> With that,
>
> Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

Great, thanks.

Luis