* [PATCH] staging: lustre: lnet: add static to libcfs_dev declaration
@ 2018-05-10 19:41 Justin Skists
2018-05-11 0:43 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Justin Skists @ 2018-05-10 19:41 UTC (permalink / raw)
To: devel, lustre-devel, James Simmons, Andreas Dilger, Oleg Drokin
Cc: linux-kernel
Add a static prefix to the declaration for libcfs_dev. This would fix
the following sparse warning:
drivers/staging/lustre/lnet/libcfs/module.c:317:19: warning: symbol
'libcfs_dev' was not declared. Should it be static?
Signed-off-by: Justin Skists <justin.skists@juzza.co.uk>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/drivers/staging/lustre/lnet/libcfs/module.c b/drivers/staging/lustre/lnet/libcfs/module.c
index ca942f474a55..e021e439f140 100644
--- a/drivers/staging/lustre/lnet/libcfs/module.c
+++ b/drivers/staging/lustre/lnet/libcfs/module.c
@@ -314,7 +314,7 @@ static const struct file_operations libcfs_fops = {
.unlocked_ioctl = libcfs_psdev_ioctl,
};
-struct miscdevice libcfs_dev = {
+static struct miscdevice libcfs_dev = {
.minor = MISC_DYNAMIC_MINOR,
.name = "lnet",
.fops = &libcfs_fops,
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: lustre: lnet: add static to libcfs_dev declaration
2018-05-10 19:41 [PATCH] staging: lustre: lnet: add static to libcfs_dev declaration Justin Skists
@ 2018-05-11 0:43 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2018-05-11 0:43 UTC (permalink / raw)
To: Justin Skists, devel, lustre-devel, James Simmons, Andreas Dilger,
Oleg Drokin
Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On Thu, May 10 2018, Justin Skists wrote:
> Add a static prefix to the declaration for libcfs_dev. This would fix
> the following sparse warning:
>
> drivers/staging/lustre/lnet/libcfs/module.c:317:19: warning: symbol
> 'libcfs_dev' was not declared. Should it be static?
Thanks - that was my fault. (b4ded66db93b)
Reviewed-by: NeilBrown <neilb@suse.com>
Thanks,
NeilBrown
>
> Signed-off-by: Justin Skists <justin.skists@juzza.co.uk>
> ---
> drivers/staging/lustre/lnet/libcfs/module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/libcfs/module.c b/drivers/staging/lustre/lnet/libcfs/module.c
> index ca942f474a55..e021e439f140 100644
> --- a/drivers/staging/lustre/lnet/libcfs/module.c
> +++ b/drivers/staging/lustre/lnet/libcfs/module.c
> @@ -314,7 +314,7 @@ static const struct file_operations libcfs_fops = {
> .unlocked_ioctl = libcfs_psdev_ioctl,
> };
>
> -struct miscdevice libcfs_dev = {
> +static struct miscdevice libcfs_dev = {
> .minor = MISC_DYNAMIC_MINOR,
> .name = "lnet",
> .fops = &libcfs_fops,
> --
> 2.17.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-11 0:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-10 19:41 [PATCH] staging: lustre: lnet: add static to libcfs_dev declaration Justin Skists
2018-05-11 0:43 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox