From: Borislav Petkov <bp@alien8.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pci/aer: Get rid of aer_recover_work_func() forward declaration
Date: Fri, 11 May 2018 21:08:42 +0200 [thread overview]
Message-ID: <20180511190842.GJ12705@pd.tnic> (raw)
In-Reply-To: <20180511190013.GI190385@bhelgaas-glaptop.roam.corp.google.com>
On Fri, May 11, 2018 at 02:00:13PM -0500, Bjorn Helgaas wrote:
> On Fri, May 11, 2018 at 06:39:23PM +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > Just move the actual function up so that it is visible to its user
> > aer_recover_queue().
>
> Good idea.
>
> Not *directly* related, but I'm really tired of the clutter of all these
> separate files, and I'm thinking of squashing
>
> drivers/pci/pcie/aer/* => drivers/pci/pcie/aer.c
> drivers/pci/pcie/portdrv* => drivers/pci/pcie/portdrv.c
> drivers/pci/hotplug/pciehp* => drivers/pci/hotplug/pciehp.c
> drivers/pci/hotplug/shpchp* => drivers/pci/hotplug/shpchp.c
> etc.
>
> That would let us make many more things static and (more importantly,
> IMO), make it easier to browse the code.
Yeah, it probably is of no use to have separate compilation units like
aerdriver-objs := aerdrv_errprint.o aerdrv_core.o aerdrv.o
for example, which practically get always built together.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-05-11 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 16:39 [PATCH] pci/aer: Get rid of aer_recover_work_func() forward declaration Borislav Petkov
2018-05-11 19:00 ` Bjorn Helgaas
2018-05-11 19:08 ` Borislav Petkov [this message]
2018-05-30 16:56 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511190842.GJ12705@pd.tnic \
--to=bp@alien8.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox