From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbeEKTJN (ORCPT ); Fri, 11 May 2018 15:09:13 -0400 Received: from mail.skyhub.de ([5.9.137.197]:35000 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbeEKTJI (ORCPT ); Fri, 11 May 2018 15:09:08 -0400 Date: Fri, 11 May 2018 21:08:42 +0200 From: Borislav Petkov To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , LKML Subject: Re: [PATCH] pci/aer: Get rid of aer_recover_work_func() forward declaration Message-ID: <20180511190842.GJ12705@pd.tnic> References: <20180511163923.22116-1-bp@alien8.de> <20180511190013.GI190385@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180511190013.GI190385@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 11, 2018 at 02:00:13PM -0500, Bjorn Helgaas wrote: > On Fri, May 11, 2018 at 06:39:23PM +0200, Borislav Petkov wrote: > > From: Borislav Petkov > > > > Just move the actual function up so that it is visible to its user > > aer_recover_queue(). > > Good idea. > > Not *directly* related, but I'm really tired of the clutter of all these > separate files, and I'm thinking of squashing > > drivers/pci/pcie/aer/* => drivers/pci/pcie/aer.c > drivers/pci/pcie/portdrv* => drivers/pci/pcie/portdrv.c > drivers/pci/hotplug/pciehp* => drivers/pci/hotplug/pciehp.c > drivers/pci/hotplug/shpchp* => drivers/pci/hotplug/shpchp.c > etc. > > That would let us make many more things static and (more importantly, > IMO), make it easier to browse the code. Yeah, it probably is of no use to have separate compilation units like aerdriver-objs := aerdrv_errprint.o aerdrv_core.o aerdrv.o for example, which practically get always built together. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.