From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751333AbeELIkO (ORCPT ); Sat, 12 May 2018 04:40:14 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36814 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbeELIkM (ORCPT ); Sat, 12 May 2018 04:40:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7C421601EA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [V2, 1/2] Revert "ssb: Prevent build of PCI host features in module" From: Kalle Valo In-Reply-To: <20180511091715.1989-1-zajec5@gmail.com> References: <20180511091715.1989-1-zajec5@gmail.com> To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: =?UTF-8?q?Michael=20B=C3=BCsch?= , Larry Finger , Matt Redfearn , linux-wireless@vger.kernel.org, Hauke Mehrtens , LKML , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180512084011.DEA1360807@smtp.codeaurora.org> Date: Sat, 12 May 2018 08:40:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rafał Miłecki wrote: > From: Rafał Miłecki > > This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e. > > Above commit added "SSB = y" dependency to the wrong symbol > SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being > selected when needed. PCI core driver for core running in clienthost > mode is important for bus initialization. It's perfectly valid scenario > to have ssb built as module and use it with buses on PCI cards. > > This fixes regression that affected all *module* users with PCI cards. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1572349 > Signed-off-by: Rafał Miłecki 2 patches applied to wireless-drivers.git, thanks. 36910d82a80c Revert "ssb: Prevent build of PCI host features in module" ebd27d3317c6 ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y -- https://patchwork.kernel.org/patch/10393729/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches