From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbeEOEpy (ORCPT ); Tue, 15 May 2018 00:45:54 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36511 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbeEOEpx (ORCPT ); Tue, 15 May 2018 00:45:53 -0400 X-Google-Smtp-Source: AB8JxZra7IfN1sXiWpMiZ/tIiIUD39z29dl2G74ngGhh03vERVy79Gc66enB5xOyuHI7cehqMlyRWg== Date: Tue, 15 May 2018 13:45:43 +0900 From: AKASHI Takahiro To: James Morse Cc: catalin.marinas@arm.com, will.deacon@arm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, dyoung@redhat.com, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, bhsharma@redhat.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 03/11] arm64: kexec_file: invoke the kernel without purgatory Message-ID: <20180515044542.GC2737@linaro.org> Mail-Followup-To: AKASHI Takahiro , James Morse , catalin.marinas@arm.com, will.deacon@arm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, dyoung@redhat.com, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, bhsharma@redhat.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20180425062629.29404-1-takahiro.akashi@linaro.org> <20180425062629.29404-4-takahiro.akashi@linaro.org> <9c830fe8-56d8-b43a-6265-43d31dffe61a@arm.com> <20180507052208.GD11326@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org James, On Fri, May 11, 2018 at 06:03:49PM +0100, James Morse wrote: > Hi Akashi, > > On 07/05/18 06:22, AKASHI Takahiro wrote: > > On Tue, May 01, 2018 at 06:46:06PM +0100, James Morse wrote: > >> On 25/04/18 07:26, AKASHI Takahiro wrote: > >>> diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > >>> index f76ea92dff91..f7dbba00be10 100644 > >>> --- a/arch/arm64/kernel/machine_kexec.c > >>> +++ b/arch/arm64/kernel/machine_kexec.c > >>> @@ -205,10 +205,17 @@ void machine_kexec(struct kimage *kimage) > > >>> cpu_soft_restart(kimage != kexec_crash_image, > >>> - reboot_code_buffer_phys, kimage->head, kimage->start, 0); > >>> + reboot_code_buffer_phys, kimage->head, kimage->start, > >>> +#ifdef CONFIG_KEXEC_FILE > >>> + kimage->purgatory_info.purgatory_buf ? > >>> + 0 : kimage->arch.dtb_mem); > >>> +#else > >>> + 0); > >>> +#endif > > > >> purgatory_buf seems to only be set in kexec_purgatory_setup_kbuf(), called from > >> kexec_load_purgatory(), which we don't use. How does this get a value? > >> > >> Would it be better to always use kimage->arch.dtb_mem, and ensure that is 0 for > >> regular kexec (as we can't know where the dtb is)? (image_arg may then be a > >> better name). > > > > The problem is arch.dtb_mem is currently defined only if CONFIG_KEXEC_FILE. > > I thought it was ARCH_HAS_KIMAGE_ARCH, which we can define all the time if > that's what we want. > > > > So I would like to > > - merge this patch with patch#8 > > - change the condition > > #ifdef CONFIG_KEXEC_FILE > > kimage->file_mode ? kimage->arch.dtb_mem : 0); > > #else > > 0); > > #endif > > If we can avoid even this #ifdef by always having kimage->arch, I'd prefer that. > If we do that 'dtb_mem' would need some thing that indicates its for kexec_file, > as kexec has a DTB too, we just don't know where it is... OK, but I want to have a minimum of kexec.arch always exist. How about this? | #define ARCH_HAS_KIMAGE_ARCH | | struct kimage_arch { | phys_addr_t dtb_mem; | #ifdef CONFIG_KEXEC_FILE | void *dtb_buf; | /* Core ELF header buffer */ | void *elf_headers; | unsigned long elf_headers_sz; | unsigned long elf_load_addr; | #endif | void machine_kexec(struct kimage *kimage) | { | ... | cpu_soft_restart(kimage != kexec_crash_image, | reboot_code_buffer_phys, kimage->head, kimage->start, | kimage->arch.dtb_mem); Thanks -Takahiro AKASHI > > > Thanks, > > James