* [PATCH] Staging:Comedi:comedi_compat32.c: Lindent changes
@ 2018-05-15 5:20 Pratik Jain
2018-05-15 9:34 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Pratik Jain @ 2018-05-15 5:20 UTC (permalink / raw)
To: abbotti; +Cc: devel, linux-kernel, Pratik Jain
Recommended indentation by Lindent on file comedi_compat32.c
Signed-off-by: Pratik Jain <pratik.jain0509@gmail.com>
---
drivers/staging/comedi/comedi_compat32.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/comedi_compat32.c b/drivers/staging/comedi/comedi_compat32.c
index 97fb9388bc22..fa9d239474ee 100644
--- a/drivers/staging/comedi/comedi_compat32.c
+++ b/drivers/staging/comedi/comedi_compat32.c
@@ -34,7 +34,7 @@
struct comedi32_chaninfo_struct {
unsigned int subdev;
compat_uptr_t maxdata_list; /* 32-bit 'unsigned int *' */
- compat_uptr_t flaglist; /* 32-bit 'unsigned int *' */
+ compat_uptr_t flaglist; /* 32-bit 'unsigned int *' */
compat_uptr_t rangelist; /* 32-bit 'unsigned int *' */
unsigned int unused[4];
};
@@ -57,16 +57,16 @@ struct comedi32_cmd_struct {
unsigned int scan_end_arg;
unsigned int stop_src;
unsigned int stop_arg;
- compat_uptr_t chanlist; /* 32-bit 'unsigned int *' */
+ compat_uptr_t chanlist; /* 32-bit 'unsigned int *' */
unsigned int chanlist_len;
- compat_uptr_t data; /* 32-bit 'short *' */
+ compat_uptr_t data; /* 32-bit 'short *' */
unsigned int data_len;
};
struct comedi32_insn_struct {
unsigned int insn;
unsigned int n;
- compat_uptr_t data; /* 32-bit 'unsigned int *' */
+ compat_uptr_t data; /* 32-bit 'unsigned int *' */
unsigned int subdev;
unsigned int chanspec;
unsigned int unused[3];
@@ -74,7 +74,7 @@ struct comedi32_insn_struct {
struct comedi32_insnlist_struct {
unsigned int n_insns;
- compat_uptr_t insns; /* 32-bit 'struct comedi_insn *' */
+ compat_uptr_t insns; /* 32-bit 'struct comedi_insn *' */
};
/* Handle translated ioctl. */
@@ -194,7 +194,7 @@ static int get_compat_cmd(struct comedi_cmd __user *cmd,
err |= __put_user(temp.uint, &cmd->stop_arg);
err |= __get_user(temp.uptr, &cmd32->chanlist);
err |= __put_user((unsigned int __force *)compat_ptr(temp.uptr),
- &cmd->chanlist);
+ &cmd->chanlist);
err |= __get_user(temp.uint, &cmd32->chanlist_len);
err |= __put_user(temp.uint, &cmd->chanlist_len);
err |= __get_user(temp.uptr, &cmd32->data);
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging:Comedi:comedi_compat32.c: Lindent changes
2018-05-15 5:20 [PATCH] Staging:Comedi:comedi_compat32.c: Lindent changes Pratik Jain
@ 2018-05-15 9:34 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2018-05-15 9:34 UTC (permalink / raw)
To: Pratik Jain; +Cc: devel, linux-kernel
On 15/05/18 06:20, Pratik Jain wrote:
> Recommended indentation by Lindent on file comedi_compat32.c
>
> Signed-off-by: Pratik Jain <pratik.jain0509@gmail.com>
> ---
> drivers/staging/comedi/comedi_compat32.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_compat32.c b/drivers/staging/comedi/comedi_compat32.c
> index 97fb9388bc22..fa9d239474ee 100644
> --- a/drivers/staging/comedi/comedi_compat32.c
> +++ b/drivers/staging/comedi/comedi_compat32.c
> @@ -34,7 +34,7 @@
> struct comedi32_chaninfo_struct {
> unsigned int subdev;
> compat_uptr_t maxdata_list; /* 32-bit 'unsigned int *' */
> - compat_uptr_t flaglist; /* 32-bit 'unsigned int *' */
> + compat_uptr_t flaglist; /* 32-bit 'unsigned int *' */
> compat_uptr_t rangelist; /* 32-bit 'unsigned int *' */
> unsigned int unused[4];
> };
> @@ -57,16 +57,16 @@ struct comedi32_cmd_struct {
> unsigned int scan_end_arg;
> unsigned int stop_src;
> unsigned int stop_arg;
> - compat_uptr_t chanlist; /* 32-bit 'unsigned int *' */
> + compat_uptr_t chanlist; /* 32-bit 'unsigned int *' */
> unsigned int chanlist_len;
> - compat_uptr_t data; /* 32-bit 'short *' */
> + compat_uptr_t data; /* 32-bit 'short *' */
> unsigned int data_len;
> };
>
> struct comedi32_insn_struct {
> unsigned int insn;
> unsigned int n;
> - compat_uptr_t data; /* 32-bit 'unsigned int *' */
> + compat_uptr_t data; /* 32-bit 'unsigned int *' */
> unsigned int subdev;
> unsigned int chanspec;
> unsigned int unused[3];
> @@ -74,7 +74,7 @@ struct comedi32_insn_struct {
>
> struct comedi32_insnlist_struct {
> unsigned int n_insns;
> - compat_uptr_t insns; /* 32-bit 'struct comedi_insn *' */
> + compat_uptr_t insns; /* 32-bit 'struct comedi_insn *' */
> };
Those all make the code look less pretty because all those comments are
nicely aligned currently.
>
> /* Handle translated ioctl. */
> @@ -194,7 +194,7 @@ static int get_compat_cmd(struct comedi_cmd __user *cmd,
> err |= __put_user(temp.uint, &cmd->stop_arg);
> err |= __get_user(temp.uptr, &cmd32->chanlist);
> err |= __put_user((unsigned int __force *)compat_ptr(temp.uptr),
> - &cmd->chanlist);
> + &cmd->chanlist);
> err |= __get_user(temp.uint, &cmd32->chanlist_len);
> err |= __put_user(temp.uint, &cmd->chanlist_len);
> err |= __get_user(temp.uptr, &cmd32->data);
>
That is the only one that is an improvement, IMHO.
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-15 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-15 5:20 [PATCH] Staging:Comedi:comedi_compat32.c: Lindent changes Pratik Jain
2018-05-15 9:34 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).