linux-next: Signed-off-by missing for commit in the pm tree

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi Rafael,

Commit

  e689ba60f1f0 ("Merge branch 'opp/genpd-pstate-updates' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm")

is missing a Signed-off-by from its author and committer.

This is probably because (despite its description) this is not a merge
commit - it seems to have been flattened in the rebase :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pm tree

[Rafael J. Wysocki]

On Tuesday, May 15, 2018 12:21:09 AM CEST Stephen Rothwell wrote:
> 
> --Sig_/LKqNOwcm4.nPHJQHAB_CO6g
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi Rafael,

Hi Stephen,

> Commit
> 
>   e689ba60f1f0 ("Merge branch 'opp/genpd-pstate-updates' of git://git.kerne=
> l.org/pub/scm/linux/kernel/git/vireshk/pm")
> 
> is missing a Signed-off-by from its author and committer.
> 
> This is probably because (despite its description) this is not a merge
> commit - it seems to have been flattened in the rebase :-(

Thanks for letting me know!

This commit shouldn't have reached you at all, sorry about that.

Should be fixed now.

Thanks,
Rafael

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1957 bytes --]

Hi all,

  ae5a0eccc85f ("ACPICA: ACPICA: check null return of ACPI_ALLOCATE_ZEROED in ac
pi_db_display_objects")
  376b0fb3ad62 ("ACPICA: acpi_resource_irq: Replace 1-element arrays with flexib
le array")
  2a85fc562679 ("ACPICA: acpi_madt_oem_data: Fix flexible array member definitio
n")
  3a287932da6a ("ACPICA: acpi_pci_routing_table: Replace fixed-size array with f
lex array member")
  6671709c6ee5 ("ACPICA: struct acpi_resource_dma: Replace 1-element array with
flexible array")
  11132ad0176e ("ACPICA: Introduce ACPI_FLEX_ARRAY")
  2a5ab99847bd ("ACPICA: struct acpi_nfit_interleave: Replace 1-element array with flexible array")
  74522fea27f8 ("ACPICA: actbl2: Replace 1-element arrays with flexible arrays")
  48ff467c338b ("ACPICA: actbl1: Replace 1-element arrays with flexible arrays")
  94bf7c8a626d ("ACPICA: struct acpi_resource_vendor: Replace 1-element array with flexible array")
  d0a874cb4519 ("ACPICA: Avoid undefined behavior: load of misaligned address")
  bf44c56a9977 ("ACPICA: Avoid undefined behavior: member access within misaligned address")
  5bd2315bd2e4 ("ACPICA: Avoid undefined behavior: member access within misaligned address")
  218387e6cf49 ("ACPICA: Avoid undefined behavior: member access within misaligned address")
  24d9609b3cd2 ("ACPICA: Avoid undefined behavior: member access within misaligned address")
  4cf8a60602f7 ("ACPICA: Avoid undefined behavior: member access within null pointer")
  05bb0167c80b ("ACPICA: Avoid undefined behavior: applying zero offset to null pointer")
  d56ba92b0ce6 ("ACPICA: Avoid undefined behavior: load of misaligned address")
  520d4a0ee5b6 ("ACPICA: add support for ClockInput resource (v6.5)")
  f5325cb10414 ("ACPICA: Add support for ASPT table in disassembler")
  86f240a2f7e9 ("ACPICA: Headers: Delete bogus node_array array of pointers from AEST table")

are missing a Signed-off-by from their authors.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

Hi all,

Commit

  ed9aa118e4e1 ("ACPICA: Add support for _DSC as per ACPI 6.5")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Hi all,

Commit

  e2605d4039a4 ("ACPI: resource: Add Infinity laptops to irq1_edge_low_force_override")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pm tree

[David McFarland]

Hi Stephen/Rafael,

Should I send another patch, or can someone add my sign-off?

I didn't realise I was supposed to add the tag, but I certainly do
sign-off on e2605d4039a4.

Sorry about that,
Dave

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

Commits

  e1d3f9d46f17 ("ACPICA: Update acpixf.h for new ACPICA release 20240322")
  ed5addd09827 ("ACPICA: Fix spelling and typos")
  5a02527783ca ("ACPICA: Clean up the fix for Issue #900")
  c15fe3916b77 ("ACPICA: Attempt 1 to fix issue #900")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Signed-off-by missing for commit in the pm tree

[Dumbre, Saket]

Hi Stephen,

I am looking into which utility I need to install inside Microsoft Visual Studio 2017/2019/2022 to automatically sign off all the commits I make from within MSVC using my Intel email address. I think I have received a similar email from you a few months ago regarding missing sign-off on ACPICA commits going into the Linux kernel, but please be assured that even the previous commits and the above commits were all signed-off by me (Saket Dumbre, ACPICA maintainer). Thank you for your email, I will ensure I will sign-off the future commits and perhaps if allowed even the past commits. 

Kind regards,
Saket Dumbre

-----Original Message-----
From: Stephen Rothwell <sfr@canb.auug.org.au> 
Sent: Monday, April 15, 2024 3:54 PM
To: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Dumbre, Saket <saket.dumbre@intel.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: Signed-off-by missing for commit in the pm tree

Hi all,

Commits

  e1d3f9d46f17 ("ACPICA: Update acpixf.h for new ACPICA release 20240322")
  ed5addd09827 ("ACPICA: Fix spelling and typos")
  5a02527783ca ("ACPICA: Clean up the fix for Issue #900")
  c15fe3916b77 ("ACPICA: Attempt 1 to fix issue #900")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

Hi all,

Commits

  c00d476cbcef ("cpufreq: amd-pstate: change cpu freq transition delay for some models")
  c7107750b2ff ("x86/cpufeatures: Add AMD FAST CPPC feature flag")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pm tree

[Mario Limonciello]

On 6/30/2024 18:15, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>    c00d476cbcef ("cpufreq: amd-pstate: change cpu freq transition delay for some models")
>    c7107750b2ff ("x86/cpufeatures: Add AMD FAST CPPC feature flag")
> 
> are missing a Signed-off-by from their committers.
> 

My apologies; this was from my first ever PR and I had make a mistake in 
not using "-sl" for b4 when I picked them up.  I've done it correctly 
for the others and will continue to be cognizant in the future.

If you can amend the commits here is the missing tags:

Link: 
https://lore.kernel.org/linux-pm/e717feea3df0a178a9951491040a76c79a00556c.1716649578.git.Xiaojian.Du@amd.com/
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

Hi all,

Commits

  5506544dc2e4 ("ACPICA: Avoid warning for Dump Functions")
  7afea7bc49c5 ("ACPICA: haiku: Fix invalid value used for semaphores")

are missing a Signed-off-by from their authors.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pm tree

[Adrien Destugues]

On 03/09/2024 00:21, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
>    5506544dc2e4 ("ACPICA: Avoid warning for Dump Functions")
>    7afea7bc49c5 ("ACPICA: haiku: Fix invalid value used for semaphores")
>
> are missing a Signed-off-by from their authors.
>
Hello,

I am the author of one of these commits, I submitted this change to the 
ACPICA repository, where it was reviewed and merged by ACPICA 
maintainers (https://github.com/acpica/acpica/pull/918). As far as I 
know, there is no requirement for a Signed-off-by in that repository, or 
at least I didn't see instructions to that effect.

I don't think I can change the commit now that it has been merged for a 
year in the ACPICA repository. So I'm not sure what I can do to help 
resolve this.

-- 

Adrien Destugues

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi all,

Commits

  9eef70365d71 ("ACPICA: Introduce ACPI_NONSTRING")
  ac9334785c75 ("ACPICA: utilities: Fix overflow check in vsnprintf()")
  5de20bc939b0 ("ACPICA: Apply pack(1) to union aml_resource")

are missing a Signed-off-by from their authors.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pm tree

[Tamir Duberstein]

On Tue, Apr 29, 2025 at 3:55 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commits
>
>   9eef70365d71 ("ACPICA: Introduce ACPI_NONSTRING")
>   ac9334785c75 ("ACPICA: utilities: Fix overflow check in vsnprintf()")
>   5de20bc939b0 ("ACPICA: Apply pack(1) to union aml_resource")
>
> are missing a Signed-off-by from their authors.

Hi Stephen, how can I remedy this for 5de20bc939b0 ("ACPICA: Apply
pack(1) to union aml_resource")?

Re: linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

Hi Tamir,

On Tue, 29 Apr 2025 16:30:43 -0700 Tamir Duberstein <tamird@gmail.com> wrote:
>
> Hi Stephen, how can I remedy this for 5de20bc939b0 ("ACPICA: Apply
> pack(1) to union aml_resource")?

That is up to Rafael.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pm tree

[Rafael J. Wysocki]

On Wednesday, April 30, 2025 1:30:43 AM CEST Tamir Duberstein wrote:
> On Tue, Apr 29, 2025 at 3:55 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > Commits
> >
> >   9eef70365d71 ("ACPICA: Introduce ACPI_NONSTRING")
> >   ac9334785c75 ("ACPICA: utilities: Fix overflow check in vsnprintf()")
> >   5de20bc939b0 ("ACPICA: Apply pack(1) to union aml_resource")
> >
> > are missing a Signed-off-by from their authors.
> 
> Hi Stephen, how can I remedy this for 5de20bc939b0 ("ACPICA: Apply
> pack(1) to union aml_resource")?

The original ACPICA commit does not carry an S-o-b from you, so this one
does not either.

If you reply with a Signed-off-by to this message:

https://lore.kernel.org/linux-acpi/4664267.LvFx2qVVIh@rjwysocki.net/

I will pick up your tag.

Thanks!

Re: linux-next: Signed-off-by missing for commit in the pm tree

[Kees Cook]

On Wed, Apr 30, 2025 at 08:32:25PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, April 30, 2025 1:30:43 AM CEST Tamir Duberstein wrote:
> > On Tue, Apr 29, 2025 at 3:55 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > Commits
> > >
> > >   9eef70365d71 ("ACPICA: Introduce ACPI_NONSTRING")
> > >   ac9334785c75 ("ACPICA: utilities: Fix overflow check in vsnprintf()")
> > >   5de20bc939b0 ("ACPICA: Apply pack(1) to union aml_resource")
> > >
> > > are missing a Signed-off-by from their authors.
> > 
> > Hi Stephen, how can I remedy this for 5de20bc939b0 ("ACPICA: Apply
> > pack(1) to union aml_resource")?
> 
> The original ACPICA commit does not carry an S-o-b from you, so this one
> does not either.
> 
> If you reply with a Signed-off-by to this message:
> 
> https://lore.kernel.org/linux-acpi/4664267.LvFx2qVVIh@rjwysocki.net/
> 
> I will pick up your tag.

Whoops, mine is missed too from ACPICA upstream. I've replied now to

https://lore.kernel.org/linux-acpi/1841930.VLH7GnMWUR@rjwysocki.net/

-- 
Kees Cook

Re: linux-next: Signed-off-by missing for commit in the pm tree

[Tamir Duberstein]

On Wed, Apr 30, 2025 at 11:32 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> On Wednesday, April 30, 2025 1:30:43 AM CEST Tamir Duberstein wrote:
> > On Tue, Apr 29, 2025 at 3:55 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > Commits
> > >
> > >   9eef70365d71 ("ACPICA: Introduce ACPI_NONSTRING")
> > >   ac9334785c75 ("ACPICA: utilities: Fix overflow check in vsnprintf()")
> > >   5de20bc939b0 ("ACPICA: Apply pack(1) to union aml_resource")
> > >
> > > are missing a Signed-off-by from their authors.
> >
> > Hi Stephen, how can I remedy this for 5de20bc939b0 ("ACPICA: Apply
> > pack(1) to union aml_resource")?
>
> The original ACPICA commit does not carry an S-o-b from you, so this one
> does not either.
>
> If you reply with a Signed-off-by to this message:
>
> https://lore.kernel.org/linux-acpi/4664267.LvFx2qVVIh@rjwysocki.net/
>
> I will pick up your tag.
>
> Thanks!

Done in https://lore.kernel.org/linux-acpi/20250430185019.19528-2-tamird@gmail.com/.

linux-next: Signed-off-by missing for commit in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

Hi all,

Commit

  8979b0e76718 ("ACPICA: utilities: Fix overflow check in vsnprintf()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]