From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
syzbot <syzbot+481ad819c717f6b78df9@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
gregkh@linuxfoundation.org, tj@kernel.org
Subject: Re: general protection fault in kernfs_kill_sb (2)
Date: Tue, 15 May 2018 10:17:12 +1000 [thread overview]
Message-ID: <20180515101712.366c0624@canb.auug.org.au> (raw)
In-Reply-To: <20180514040415.GD30522@ZenIV.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
Hi Al,
On Mon, 14 May 2018 05:04:15 +0100 Al Viro <viro@ZenIV.linux.org.uk> wrote:
>
> On Mon, May 14, 2018 at 12:20:16PM +0900, Tetsuo Handa wrote:
>
> > But there remains a refcount bug because deactivate_locked_super() from
> > kernfs_mount_ns() triggers kobj_ns_drop() from sysfs_kill_sb() via
> > sb->kill_sb() when kobj_ns_drop() is always called by sysfs_mount()
> > if kernfs_mount_ns() returned an error.
>
> Trivial:
>
> unfuck sysfs_mount()
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
I noticed this turn up in linux-next today. Can I ask that you please
add an actual commit message to it before sending it on to Linus.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-05-15 0:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 17:01 general protection fault in kernfs_kill_sb (2) syzbot
2018-05-13 2:19 ` Tetsuo Handa
2018-05-14 2:47 ` Al Viro
[not found] ` <201805140320.w4E3KG2o056158@www262.sakura.ne.jp>
2018-05-14 4:04 ` Al Viro
2018-05-14 4:32 ` Al Viro
2018-05-15 0:17 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515101712.366c0624@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzbot+481ad819c717f6b78df9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox