linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Don Hiatt <don.hiatt@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	Sean Hefty <sean.hefty@intel.com>,
	OFED mailing list <linux-rdma@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	Hal Rosenstock <hal@dev.mellanox.co.il>
Subject: Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys
Date: Wed, 16 May 2018 12:16:55 -0600	[thread overview]
Message-ID: <20180516181655.GH25661@ziepe.ca> (raw)
In-Reply-To: <FDEBA43A-C98F-4E2B-A8F3-CA809FBAD479@oracle.com>

On Wed, May 16, 2018 at 08:14:50PM +0200, Håkon Bugge wrote:
> 
> 
> > On 16 May 2018, at 20:01, Jason Gunthorpe <jgg@ziepe.ca> wrote:
> > 
> > On Wed, May 16, 2018 at 07:46:10PM +0200, Håkon Bugge wrote:
> > 
> >>   OK. Lets take one example. The pkey table contains 0xFFFF, 0x8001,
> >>   0x0001.
> >> 
> >>   The wce.pkey_index is 1 (i.e., pointing to 0x8001). Now, tell me, was
> >>   BTH.PKey 0x8001 (matches 0x8001) or was it 0x0001 (also matching
> >>   0x8001) ?
> > 
> > As far as the Linux core is concerned, it must have been 0x8001,
> > because the only way the pkey_index feature works properly is if
> > exact-match takes precedence over in-exact match.
> 
> And now if the table only contains 0xFFFF, 0x8001, how do you tell?

It doesn't matter.

The delgation of Pkeys to VMs are on a pkey-table-index basis, so if
it matches table entry 1 and entry 1 is passed to the VM, then the
packet can be passed to the VM.

Jason

  reply	other threads:[~2018-05-16 18:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09  9:30 [PATCH IB/core 0/2] Do not form IB connections between limited partition members Håkon Bugge
2018-05-09  9:30 ` [PATCH IB/core 1/2] IB/core: A full pkey is required to match a limited one Håkon Bugge
2018-05-09  9:30 ` [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys Håkon Bugge
2018-05-09 11:28   ` Hal Rosenstock
2018-05-10  9:16     ` Håkon Bugge
2018-05-10 14:01       ` Hal Rosenstock
2018-05-10 15:16         ` Håkon Bugge
2018-05-10 16:54           ` Hal Rosenstock
2018-05-11 10:55             ` Håkon Bugge
2018-05-11 12:51               ` Hal Rosenstock
2018-05-14 21:04               ` Jason Gunthorpe
2018-05-14 21:02           ` Jason Gunthorpe
2018-05-15  0:38             ` Hal Rosenstock
2018-05-15 18:11               ` Håkon Bugge
2018-05-15 19:04                 ` Jason Gunthorpe
2018-05-16  6:47                   ` Håkon Bugge
2018-05-16 15:12                     ` Jason Gunthorpe
2018-05-16 16:42                       ` Hal Rosenstock
2018-05-16 16:57                         ` Jason Gunthorpe
     [not found]                         ` <151B2A36-28F0-4A88-8633-31AE7E55F848@oracle.com>
2018-05-16 18:01                           ` Jason Gunthorpe
2018-05-16 18:14                             ` Håkon Bugge
2018-05-16 18:16                               ` Jason Gunthorpe [this message]
     [not found]                                 ` <A087A721-E596-428E-8554-FAEB4BE9B306@oracle.com>
2018-05-16 19:30                                   ` Hal Rosenstock
2018-05-09 18:11   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516181655.GH25661@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=dledford@redhat.com \
    --cc=don.hiatt@intel.com \
    --cc=haakon.bugge@oracle.com \
    --cc=hal@dev.mellanox.co.il \
    --cc=ira.weiny@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).