public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jin Yao <yao.jin@linux.intel.com>,
	jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
	ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf annotate: Support multiple events without group
Date: Thu, 17 May 2018 22:27:41 +0200	[thread overview]
Message-ID: <20180517202741.GD12497@krava> (raw)
In-Reply-To: <20180517162750.GB18538@kernel.org>

On Thu, May 17, 2018 at 01:27:50PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, May 10, 2018 at 09:59:22PM +0800, Jin Yao escreveu:
> > See example,
> > 
> > perf record -e cycles,branches ./div
> > perf annotate main --stdio or
> > perf annotate main --stdio2 or
> > perf annotate main
> > 
> > The "perf annotate" should show both cycles and branches on the
> > left side, but actually it only shows one event cycles.
> > 
> > It works with events group like:
> > perf record -e "{cycles,branches}" ./div
> > 
> > It should work too even without group.
> 
> Humm, I think that this should be done the way it is for perf report,
> i.e. you select the group output by using --group, no?
> 
> Jiri, isn't that how it is done in 'perf report' for non-explicit
> groups?

yep, if there's no event group, the --group will enable the group
output in report.. sounds ok to follow this also in annotate

'perf report' TUI offers list of events to choose from
and the --stdio version prints report for each event
annotate could do the same

jirka

  reply	other threads:[~2018-05-17 20:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 13:59 [PATCH] perf annotate: Support multiple events without group Jin Yao
2018-05-17  4:53 ` Jin, Yao
2018-05-17 16:27 ` Arnaldo Carvalho de Melo
2018-05-17 20:27   ` Jiri Olsa [this message]
2018-05-18  0:28     ` Jin, Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517202741.GD12497@krava \
    --to=jolsa@redhat.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox