Re: [PATCH v1 11/11] ARM: tegra: Create platform device for tegra20-cpufreq driver

Thierry Reding
2018-05-18T09:14:13Z

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

On Thu, May 17, 2018 at 09:00:56PM +0300, Dmitry Osipenko wrote:
> Tegra20-cpufreq driver require a platform device in order to be loaded,
> instantiate a simple platform device for the driver during of the machines
> late initialization.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> arch/arm/mach-tegra/tegra.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
> index 02e712d2ea30..f9587be48235 100644
> --- a/arch/arm/mach-tegra/tegra.c
> +++ b/arch/arm/mach-tegra/tegra.c
> @@ -97,6 +97,10 @@ static void __init tegra_dt_init_late(void)
> if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) &&
> of_machine_is_compatible("compal,paz00"))
> tegra_paz00_wifikill_init();
> +
> + if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) &&
> + of_machine_is_compatible("nvidia,tegra20"))
> + platform_device_register_simple("tegra20-cpufreq", -1, NULL, 0);
> }
>
> static const char * const tegra_dt_board_compat[] = {

Tegra124 has a CPU frequency driver that is similar to this and it
contains code that will instantiate the platform device from the CPU
frequency driver's module_init function.

I think the primary reason for doing that was to not tie the code to
32-bit ARM, even though it never runs on anything but that, so it's
slightly over-engineered.

I don't mind either way, and it's easy enough to change this to
something else later on if we want. I'll pick this up into the Tegra
tree.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]